-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Volume gesture not working on some phones #680
Conversation
anilbeesetti
commented
Oct 10, 2023
- fixes [BUG] Volume Gesture #637
0875c20
to
fad5589
Compare
@Yashraj254 maybe test this apk: https://github.com/anilbeesetti/nextplayer/suites/17141015660/artifacts/979286360. If this doesn't work we can try removing the gesture exclusion check |
This one working fine if i leave navigation bar area. So I'm fine with this. |
@anilbeesetti it works fine now.. if we exclude the navigation bar area... its much better than before.. |
Could you elobrate. What do you mean by exclude the navigation bar area |
@anilbeesetti the area that is covered by system navigation buttons.. |
d427ca5
to
8e76afa
Compare
Hey @Yashraj254, @anuraag488. Could you test this fix and let me know is it better or worse: https://github.com/anilbeesetti/nextplayer/suites/17238705412/artifacts/984919972 |
Previous build was better than this. Volume gesture doesn't work close to navigation bar while previous one is working. |
i don't see any difference, it feels same as earlier just the system nav bar area is excluded. |
Here is video of both builds. There is slight difference in gesture area. new.build.mp4old.build.mp4 |
its better to use the previous build then.. |
8e76afa
to
15a7fa7
Compare