Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Volume gesture not working on some phones #680

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

anilbeesetti
Copy link
Owner

@anilbeesetti
Copy link
Owner Author

@Yashraj254 maybe test this apk: https://github.com/anilbeesetti/nextplayer/suites/17141015660/artifacts/979286360. If this doesn't work we can try removing the gesture exclusion check

@anuraag488
Copy link

@Yashraj254 maybe test this apk: https://github.com/anilbeesetti/nextplayer/suites/17141015660/artifacts/979286360. If this doesn't work we can try removing the gesture exclusion check

This one working fine if i leave navigation bar area. So I'm fine with this.

@Yashraj254
Copy link
Contributor

@anilbeesetti it works fine now.. if we exclude the navigation bar area... its much better than before..

@anilbeesetti
Copy link
Owner Author

@anilbeesetti it works fine now.. if we exclude the navigation bar area... its much better than before..

Could you elobrate. What do you mean by exclude the navigation bar area

@Yashraj254
Copy link
Contributor

Yashraj254 commented Oct 14, 2023

@anilbeesetti the area that is covered by system navigation buttons..
whether i use system navigation buttons or Gestures that portion of screen is excluded..for volume controls

sample

@anilbeesetti
Copy link
Owner Author

Hey @Yashraj254, @anuraag488. Could you test this fix and let me know is it better or worse: https://github.com/anilbeesetti/nextplayer/suites/17238705412/artifacts/984919972

@anuraag488
Copy link

Hey @Yashraj254, @anuraag488. Could you test this fix and let me know is it better or worse: https://github.com/anilbeesetti/nextplayer/suites/17238705412/artifacts/984919972

Previous build was better than this. Volume gesture doesn't work close to navigation bar while previous one is working.

@Yashraj254
Copy link
Contributor

Hey @Yashraj254, @anuraag488. Could you test this fix and let me know is it better or worse: https://github.com/anilbeesetti/nextplayer/suites/17238705412/artifacts/984919972

i don't see any difference, it feels same as earlier just the system nav bar area is excluded.

@anuraag488
Copy link

anuraag488 commented Oct 15, 2023

Here is video of both builds. There is slight difference in gesture area.

new.build.mp4
old.build.mp4

@Yashraj254
Copy link
Contributor

Here is video of both builds. There is slight difference in gesture area.

new.build.mp4
old.build.mp4

its better to use the previous build then..

@anilbeesetti anilbeesetti merged commit 5f4584c into main Nov 1, 2023
3 checks passed
@anilbeesetti anilbeesetti deleted the fix-volume-gesture branch November 1, 2023 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Volume Gesture
3 participants