Child process cleanup and debug information #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added debug information when child process exits - pid of child process (service) - exit code (this should help for debuging issues related to "Session closed") * Fixed status checking from waitpid() when child process exits - before we were checking wrong variable (checks were allways true) - now we use correct status variable
When browser tab/window is closed during active session, child process stays alive forever (even if shellinaboxd is terminated). https://code.google.com/p/shellinabox/issues/detail?id=103 https://code.google.com/p/shellinabox/issues/detail?id=203 * If session timeouts cleanup procedure is triggered. Procedure is executed in launcher process, because this is parent of child (service) process. There we can check, if we have correct child pid (stored in session) and than we can terminate process. * Added debug information about cleaning up child process * Fixed debug formatting from previous commit
Disable SSLv2, SSLv3, and compression; generate new DH or ECDH keys during each handshake; always start a new session on server renegotiation; set a strong cipher list. Signed-off-by: Anders Kaseorg <andersk@mit.edu> [ Patch from https://code.google.com/p/shellinabox/issues/detail?id=215 ]
|
I added some extra patches found on https://code.google.com/p/shellinabox/issues/list ... |
|
Thanks -- I'll take a look and integrate when I get a chance. |
Now we are able to identify IE11 as MSIE browser and disable compresion. Patch taken from issue comments. https://code.google.com/p/shellinabox/issues/detail?id=262
|
anilgulecha did you get time to test and integrate this in master? |
|
@jerryjacobs Hi, we have this tested and integrated in our fork of shellinabox. There are also some other fixes and improvements. |
|
Hello, i run ubuntu and i tried to follow the install process for debian, this was the result. Please see if you can help me :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, i made some fixes for handling child process on session timeout and added some debug messages.
I have tested the changes on Ubuntu 12.04.4 and CentOS 6.6 and I think they work fine. Do you think that changes are OK and that you can merge them in your fork?
Have a nice day :)