Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs variants #222

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Tabs variants #222

merged 2 commits into from
Jan 23, 2024

Conversation

hobbescodes
Copy link
Contributor

Description

Task link: https://trello.com/c/QzIleSet/355-add-variants-for-tabs-components, https://trello.com/c/jrLnB4Jh/526-tab-indicator-doesnt-render-appropriately-%F0%9F%A6%A4

Added enclosed, outline, and different size variants to Tabs recipe. Also fixed issue with indicator not rendering appropriately for default line variant for Tabs component.

Test Steps

  1. Verify that styles look good and that all variants render appropriately in both SB and downstream apps.

Copy link

changeset-bot bot commented Jan 23, 2024

🦋 Changeset detected

Latest commit: f497ad6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@animareflection/ui Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Deploy preview for ui-storybook ready!

✅ Preview
https://ui-storybook-h4016b8vm-animareflection.vercel.app

Built with commit f497ad6.
This pull request is being automatically deployed with vercel-action

Copy link
Contributor

@coopbri coopbri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@hobbescodes hobbescodes merged commit ae57729 into master Jan 23, 2024
2 checks passed
@hobbescodes hobbescodes deleted the feat/tabs-variants branch January 23, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants