-
Notifications
You must be signed in to change notification settings - Fork 16.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark Mode Option for the Website #1126
Comments
I don't feel the need, but I'd gladly merge a nicely done PR with this. So, feel free to work on that if you want to ;D |
Cheers! @eltonmesquita can you please assign it to me... |
Hey |
Currently, in the works... |
Add this to v5 release @eltonmesquita |
#1217 Solves this. Did you have a look at it @warengonzaga ? |
@eltonmesquita yes that works... I'm gonna improve his PR when I got some time. |
No need for hurry, I'll leave a review there soon, but when you have time, it'd be nice to suggest improvements and share your ideas there, so no work is wasted 😉 |
@eltonmesquita assign @mehmetsagir for the task as he has the PR. |
I can't do that as he's not in the org nor this conversation. |
Hi @eltonmesquita, what's the plan here? It seems both is not responding? |
@warengonzaga I made the final edits for the PR(#1217 ) and sent it. However, I have not yet received a response. I can completely take over the dark mode feature if you want. |
Yeah, all good I'm waiting for @eltonmesquita decision. |
Solved by #1217 . |
There is PR #1125 which is might suggesting a dark mode option for the documentation site. I don't know if this is necessary but I would like to work on it to add that. However, to add that we need votes for this feature to be added. Just react thumbs up on this Issue and if you have additional suggestion just let us know. Thank you!
Tagging @eltonmesquita and @daneden, what do you think team?
The text was updated successfully, but these errors were encountered: