Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Mode Option for the Website #1126

Closed
warengonzaga opened this issue Sep 27, 2020 · 14 comments
Closed

Dark Mode Option for the Website #1126

warengonzaga opened this issue Sep 27, 2020 · 14 comments
Labels

Comments

@warengonzaga
Copy link
Member

There is PR #1125 which is might suggesting a dark mode option for the documentation site. I don't know if this is necessary but I would like to work on it to add that. However, to add that we need votes for this feature to be added. Just react thumbs up on this Issue and if you have additional suggestion just let us know. Thank you!

Tagging @eltonmesquita and @daneden, what do you think team?

@eltonmesquita
Copy link
Collaborator

I don't feel the need, but I'd gladly merge a nicely done PR with this. So, feel free to work on that if you want to ;D

@warengonzaga
Copy link
Member Author

warengonzaga commented Sep 28, 2020

Cheers! @eltonmesquita can you please assign it to me...

@gurnoor-garry
Copy link

Hey
I want to work on this issue. Could u please assign it to me??

@warengonzaga
Copy link
Member Author

Hey
I want to work on this issue. Could u please assign it to me??

Currently, in the works...

@warengonzaga
Copy link
Member Author

Add this to v5 release @eltonmesquita

@eltonmesquita
Copy link
Collaborator

#1217 Solves this. Did you have a look at it @warengonzaga ?

@warengonzaga
Copy link
Member Author

@eltonmesquita yes that works... I'm gonna improve his PR when I got some time.

@eltonmesquita
Copy link
Collaborator

No need for hurry, I'll leave a review there soon, but when you have time, it'd be nice to suggest improvements and share your ideas there, so no work is wasted 😉

@warengonzaga warengonzaga removed their assignment Feb 9, 2021
@warengonzaga
Copy link
Member Author

@eltonmesquita assign @mehmetsagir for the task as he has the PR.

@eltonmesquita
Copy link
Collaborator

I can't do that as he's not in the org nor this conversation.

@warengonzaga
Copy link
Member Author

Hi @eltonmesquita, what's the plan here? It seems both is not responding?

@mehmetsagir
Copy link
Contributor

mehmetsagir commented Jun 10, 2021

@warengonzaga I made the final edits for the PR(#1217 ) and sent it. However, I have not yet received a response. I can completely take over the dark mode feature if you want.

@warengonzaga
Copy link
Member Author

@warengonzaga I made the final edits for the PR(#1217 ) and sent it. However, I have not yet received a response. I can completely take over the dark mode feature if you want.

Yeah, all good I'm waiting for @eltonmesquita decision.

@eltonmesquita
Copy link
Collaborator

Solved by #1217 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants