Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate a CSS module file #933

Closed
linconkusunoki opened this issue May 8, 2019 · 8 comments
Closed

Generate a CSS module file #933

linconkusunoki opened this issue May 8, 2019 · 8 comments
Assignees
Projects

Comments

@linconkusunoki
Copy link

linconkusunoki commented May 8, 2019

Create a file called animate.module.css in the build process, so we can import it in our React components that supports CSS modules

import animation from 'animate.css/animate.module.css'

And use like that

export const Animation = ({ name }) => (
    <div className={animation[name]}>
        {children}
    </div>
)
<Animation name="pulse">Heart</Animation>
@warengonzaga
Copy link
Member

@linconkusunoki thanks for the suggestion we will add this on the next version of animate.css @eltonmesquita can you please review this one and add a proper label. Thank you!

@eltonmesquita
Copy link
Collaborator

Although I don't like the idea of adding a duplicated file just to fit the convention of a single boilerplate project (this is a CRA thing), this makes sense and can make developers life easier.
So, yeah this will probably end up on the v4 release.

Just a small question, would be better to provide the minified or unminified version? I think that the end result will be the same...

Thanks for the suggestion!

@warengonzaga
Copy link
Member

@eltonmesquita awesome feedback thanks for the response.

@linconkusunoki
Copy link
Author

Yeah, it's just to not create this file in the our personal projects and update it manually.
If the file is minified or not doesn't matter, because CRA will do it when runs the yarn build command.

Thanks for accepting my suggestion 😃

@warengonzaga
Copy link
Member

@linconkusunoki you're welcome! Expect this feature in v4.

eltonmesquita added a commit that referenced this issue Jun 5, 2019
@eltonmesquita eltonmesquita added this to Build System & Dev Tools in 4.0 Release Jul 1, 2019
@eltonmesquita
Copy link
Collaborator

eltonmesquita commented Apr 20, 2020

The next version will be completely name-spaced and class clashing will be hardly a problem any time on any project. So, I think that we won't need the .module.css file. Any thoughts on that?

@jabranr
Copy link
Contributor

jabranr commented Apr 21, 2020

I agree. It would be purely an overhead on maintenance.

@eltonmesquita
Copy link
Collaborator

Cool. All settled then, I'll close this.

Thanks for the inputs!

eltonmesquita added a commit that referenced this issue May 7, 2020
* New animations added

* Update

* Update

* Update

* Update

* kill bower

* Turn off animations for print media query (#856)

* Add a feature to turn off animations for printing as requested.
* Add print media type
* Update the builds

* Moved away from gulp to npx + postcss

This PR changes the build system for a simpler one, using only npx as runner and postcss to process all the files.
* Solves #618
* Solves #836
* Also solves #758 just for fun ;P

* Updated travis and removed animate-config.json

* Removed strayed gulpfile and trimmed the header

* Moved prefix config to package.json and updated the tasks

* Updated travis

* Updated dependencies and postcss config

* Now using CSS custom properties

* Add css module file - solves #933

* Updated README for the new build

* Rebulit files

* Updated dependencies + added browserlist

* Fixed small typo on README

* Added imports to Back animations

* Added FadeInTopLeft.css file

Fade in the animation diagonally

* Added fadeInTopRight.css file

Fade in the animation diagonally

* Added fadeInBottomLeft.css

* Added fadeInBottomRight.css

* Added fadeOutTopLeft.css

* Added fadeOutTopRight.css

* Added fadeOutBottomRight.css

* Added fadeOutBottomLeft.css

* Added imports to diagonal fadings

* Aditional formatting

* Added diagonal fadings to README

* Fixes #966

* Animate.css v4 Updates (#1029)

* Update to v4

* Add Iteration-Count CSS utility classes solves #998

* Updated builds

* Update lightSpeed animations

* Update builds

* Fix Invalid CSS Media Query Syntax

* Update build

* Add gitpod support

* Add newline in gitpod file

* Update README

* Revert

* Declare variable

* Update builds

* Remove Gitpod support

Co-authored-by: Waren Gonzaga <warengonzaga.dev@gmail.com>

* Improves building process and package.json tidy up

* Improved animations (#901)

* Improved bounce

* Improved pulse

* Improved bounceInDown

* Improved bounceInLeft

* Improved bounceInRight

* Improved bounceInUp

* Improved bounceOutDown

* Improved bounceOuLeft

* Improved bounceOuRight

* Improved bounceOutRight

* Improved fadeInDown

* Improved fadeInDownBig

* Improved fadeInLeft

* Improved fadeInLeftBig

* Improved fadeInRightBig

* Improved fadeInUp

* Improved fadeInUpBig

* Improved fadeInRight

* Reverted fade animations

* Compiled

* Updated prefers-reduced-motion support on README

* Add .delay-1s (#982)

The .delay-1s is missing from the readme

* HTTPS relevant links on README (#972)

prevents HTTP redirects

* Create CONTRIBUTING.md (#1033)

Co-authored-by: Melek REBAI <melek.rebai89@gmail.com>
Co-authored-by: Christian Oliff <christianoliff@yahoo.com>
Co-authored-by: Daniel Eden <dan.eden@me.com>

* Updates dependencies

* Updates prettier config

* refactory transform-origin in styles

* animation shake with X and Y options 🔨

* Adds shakeX and shakeY to the build

* Set 0 Opacity to Out animation classes (#1043)

* Update issue templates

* Add 0 opacity to out classes

* Update builds

* Improved implemenation

* Update builds

* Update current readme

* Update builds

Co-authored-by: Elton Mesquita <callmeelton@gmail.com>
Co-authored-by: Waren Gonzaga <warengonzaga.dev@gmail.com>

* Removes prefix from att selector

* Feature/new demo site (#1046)

* Simplify & centralize the Animate.css home page. Finally.

* Design tweak

* Fix Lightspeed demos

* Fix Lightspeed demos (cont.)

* Trigger animation on change as well as click

* Correct jQuery example. Fixes #127

* Remove Readme on gh-pages to prevent mistakes like ee75b81

* Use animate.min.css because whatever

* Update demo page with MS animation JS hooks.

* Updating home page with rubberBand animation.

* Reverse hue animation

Red-orange-brown isn’t a great first impression.

* Add readme, use cssmin minified CSS instead of csso

* Update gh-pages

* Remove protocol from urls

Fixes Chrome’s SSL issue

* Remove Square Cash link

Donations are weird, and only US account holders could use this.

* Updating Gh-page animate.css to the current version

This is a simple commit, bringing animate.css up to date with the current master version.

* Updating Gh-page animate.min.css to reflect the current version

This is a simply update to the Animate.min.css file, to reflect the current version

* Update CSS

* Updating Gh-page index.html to the reflect the addition of zooms (in out down etc)

This adds the optgroup "zoom", and associated options of: ZoomIn, zoomOut, zoomInDown, zoomInUp, zoomInLeft, zoomInRight, zoomOutLeft, zoomOutRight, zoomOutUp, and zoomOutDown.

* refactoring index.html to mimic the current optgroup styling

I added zooms, which were absent, but added them in a way that didn't reflect the current optgroup styling and delineation. I fixed that and now exits and entrances are grouped appropriately.

* updated index.html to reflect the standard optgroup styling on sliders, added slideInDown

In addition to adding slider keyframes that were missing, I placed them into the appropriate optgroups to mimic the similar styling of the other animations.

* Merging updated version of animate.min.css

As requested, this is the updated version of animate.min.css that @daneden request I include in the pull request.

* Updated animate.min.css

Made it the new version

* added jello to options

* Update CSS

* Add jackInTheBox to gh-pages (#694)

* New Special - jackInTheBox

* copy min.css from master branch

* fixed the issue of overflow scroll (#740)

for more see this issue #739

* Adds heartBeat animation demo (#893)

* Update animate.min.css to latest version

* Updated CSS for current browsers

* Updated animate.css

* Removed useless test folder

* Added warn about prefers-reduced-motion

* Adds docs compiler

* Adds new base template

* Improves the docs compiler

* Fixes flipOutY animation

* Updates docs template and build

* Reorder docs sections

* Updates docs animation list template

* Updates prettier ignore

* Adds syntax highlight to docs

* Small fixes to docs content

* Updates templates HTML

* Styles the demo website

* Adds functionality to demo website

* Fixes small website demo issue with medium screens

* Adds copy animation to demo site

* Renames loop classes to repeat

* Small adjusts to docs styles

* Updates docs template

* Updates docs  improving copy and adding sections

* Reviews the docs copy

* Fix some issues with demo-site

* Fixes issue with the demo-site playground

* Adjusts tooltip on demo-site

* Fix layout issues on mobile and update “close” button for animations list

Co-authored-by: Daniel Eden <dan.eden@me.com>
Co-authored-by: Matt Willis <contact@mrwillis.net>
Co-authored-by: Gabrielmtn <Gabrielmtn@gmail.com>
Co-authored-by: Indy Prieto <proforced@gmail.com>
Co-authored-by: Robert Pemberton <hellorobertp@gmail.com>
Co-authored-by: Khaled nuur <kahalidnuur@gmail.com>
Co-authored-by: Vladimir Jovanović <vladimir.jovanovic993@gmail.com>

* Updates docs folders

* Fix some small documentation issues

* Updates edit on github link

Co-authored-by: Arda Gedik <arnoldsivastanegezer@hotmail.com>
Co-authored-by: Arda Gedik <ardagedikk@hotmail.com>
Co-authored-by: Jabran Rafique <jabran.rafique@ratedpeople.com>
Co-authored-by: Waren Gonzaga <waren.gonzaga.dev@gmail.com>
Co-authored-by: Jabran Rafique⚡️ <jabranr@users.noreply.github.com>
Co-authored-by: Vaibhav Tandon <vaibhav.tandongcet@gmail.com>
Co-authored-by: Waren Gonzaga <warengonzaga.dev@gmail.com>
Co-authored-by: Melek REBAI <melek.rebai89@gmail.com>
Co-authored-by: Christian Oliff <christianoliff@yahoo.com>
Co-authored-by: Daniel Eden <dan.eden@me.com>
Co-authored-by: Lucas Ferreira Lima <lucasferreiralimax@gmail.com>
Co-authored-by: Matt Willis <contact@mrwillis.net>
Co-authored-by: Gabrielmtn <Gabrielmtn@gmail.com>
Co-authored-by: Indy Prieto <proforced@gmail.com>
Co-authored-by: Robert Pemberton <hellorobertp@gmail.com>
Co-authored-by: Khaled nuur <kahalidnuur@gmail.com>
Co-authored-by: Vladimir Jovanović <vladimir.jovanovic993@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
4.0 Release
Build System & Dev Tools
Development

No branches or pull requests

4 participants