Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add fishery and faker, rewrite mock objects to use the same #187

Merged
merged 3 commits into from
Sep 22, 2023
Merged

add fishery and faker, rewrite mock objects to use the same #187

merged 3 commits into from
Sep 22, 2023

Conversation

Vedu1996
Copy link
Contributor

@Vedu1996 Vedu1996 commented Sep 13, 2023 •
edited by belgamo

closes #185

@Vedu1996 Vedu1996 mentioned this pull request Sep 13, 2023
Closed
belgamo
belgamo requested changes Sep 17, 2023
View reviewed changes
Copy link
Collaborator

@belgamo belgamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase your branch, we no longer have the @animavita/models package.

apps/backend/test/factories/adoption.ts Show resolved Hide resolved
belgamo
belgamo requested changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@belgamo belgamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the broken tests. You can check if tests are breaking by running pnpm backend test and pnpm backend test:e2e

@Vedu1996
Copy link
Contributor Author

@belgamo Sorry :(, overlooked the actual values of the mock objects

belgamo
belgamo previously approved these changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@belgamo belgamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the awesome PR!

@belgamo belgamo merged commit 4d0b5f0 into animavita:v2 Sep 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@belgamo belgamo belgamo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace mock objects with fakerjs
3 participants
@Vedu1996 @belgamo @vlakshminarayanan