Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerize graphql package externals services #84

Merged
merged 5 commits into from
May 19, 2021
Merged

Dockerize graphql package externals services #84

merged 5 commits into from
May 19, 2021

Conversation

belgamo
Copy link
Collaborator

@belgamo belgamo commented May 12, 2021

Summary

The goal is to make easier for the new contributors the setup of this project and decrease the need to create externals accounts like AWS which requires a credit card.

Changelog

  • Added a docker-compose file in GraphQL package
  • Updated contribution guide
  • Updated env vars config files to replace them when using docker

@belgamo belgamo requested a review from renanmav May 12, 2021 12:54
@belgamo belgamo changed the title Dockerize graphql package externals dependencies Dockerize graphql package externals services May 12, 2021
packages/graphql/docker-compose.yml Outdated Show resolved Hide resolved
packages/graphql/docker-compose.yml Outdated Show resolved Hide resolved
@petruspierre
Copy link

Great job 🚀

@petruspierre
Copy link

I think it's valid to investigate if Android will have trouble finding the bucket data, now that it's on localhost.
For example, profile pictures may not appear in the android app.

@belgamo belgamo merged commit 7e57359 into animavita:next May 19, 2021
@belgamo belgamo deleted the chore/dockerize-graphql branch May 19, 2021 04:05
@belgamo belgamo mentioned this pull request Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants