v1.0.0 is BC

anime-db · Oct 2, 2016 · 0ec9040 · 0ec9040
1 parent 64cadae
commit 0ec9040
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 26 deletions.
diff --git a/src/Client/GitHub.php b/src/Client/GitHub.php
@@ -52,7 +52,8 @@ public function getLastRelease($repository)
         $last_tag = [];
         foreach ($this->getTags($repository) as $tag) {
             if (($version = Composer::getVersionCompatible($tag['name'])) &&
-                (!$last_version || version_compare($version, $last_version) != -1)
+                (!$last_version || version_compare($version, $last_version, '>=')) &&
+                version_compare($version, '1.0.0', '<') // v1.0.0 is BC
             ) {
                 $last_version = $version;
                 $last_tag = $tag;

diff --git a/src/Tests/Client/GitHubTest.php b/src/Tests/Client/GitHubTest.php
@@ -37,52 +37,58 @@ public function getTags()
         return [
             [
                 [
-                    ['name' => '1.0'], // bad version
-                    ['name' => '1.0.0'],
-                    ['name' => '1.1.0-dev'],
-                    ['name' => '1.1.0-patch'],
-                    ['name' => '1.1.0-alpha'],
-                    ['name' => '1.1.0-beta'],
-                    ['name' => '1.1.0'],
-                    ['name' => '1.1.0-RC'],
+                    ['name' => '0.1'], // bad version
+                    ['name' => '0.1.0'],
+                    ['name' => '0.1.0-dev'],
+                    ['name' => '0.1.0-patch'],
+                    ['name' => '0.1.0-alpha'],
+                    ['name' => '0.1.0-beta'],
+                    ['name' => '0.1.0'],
+                    ['name' => '0.1.0-RC'],
+                    ['name' => '1.0.0'], // BC
                 ],
-                ['name' => '1.1.0-RC'],
+                ['name' => '0.1.0-RC'],
             ],
             [
                 [
-                    ['name' => '1.1.0-dev2'],
-                    ['name' => '1.1.1-dev'],
+                    ['name' => '0.1.0-dev2'],
+                    ['name' => '0.1.1-dev'],
+                    ['name' => '1.0.0'], // BC
                 ],
-                ['name' => '1.1.1-dev'],
+                ['name' => '0.1.1-dev'],
             ],
             [
                 [
-                    ['name' => '1.1.0-patch'],
-                    ['name' => '1.1.0-patch2'],
+                    ['name' => '0.1.0-patch'],
+                    ['name' => '0.1.0-patch2'],
+                    ['name' => '1.0.0'], // BC
                 ],
-                ['name' => '1.1.0-patch2'],
+                ['name' => '0.1.0-patch2'],
             ],
             [
                 [
-                    ['name' => '1.1.0-alpha3'],
-                    ['name' => '1.1.0-alpha1'],
+                    ['name' => '0.1.0-alpha3'],
+                    ['name' => '0.1.0-alpha1'],
+                    ['name' => '1.0.0'], // BC
                 ],
-                ['name' => '1.1.0-alpha3'],
+                ['name' => '0.1.0-alpha3'],
             ],
             [
                 [
-                    ['name' => '1.1.0-beta'],
-                    ['name' => '1.1.0-alpha'],
-                    ['name' => '1.1.0-beta4'],
+                    ['name' => '0.1.0-beta'],
+                    ['name' => '0.1.0-alpha'],
+                    ['name' => '0.1.0-beta4'],
+                    ['name' => '1.0.0'], // BC
                 ],
-                ['name' => '1.1.0-beta4'],
+                ['name' => '0.1.0-beta4'],
             ],
             [
                 [
-                    ['name' => '1.1.0-rc1'],
-                    ['name' => '1.1.0-RC'],
+                    ['name' => '0.1.0-rc1'],
+                    ['name' => '0.1.0-RC'],
+                    ['name' => '1.0.0'], // BC
                 ],
-                ['name' => '1.1.0-RC'],
+                ['name' => '0.1.0-RC'],
             ],
         ];
     }