allow override User Agent from parameters

anime-db · Jul 21, 2017 · c6c18f9 · c6c18f9
1 parent bc67396
commit c6c18f9
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 3 deletions.
diff --git a/src/Service/Browser.php b/src/Service/Browser.php
@@ -56,8 +56,10 @@ public function __construct(Client $client, $host, $prefix, $app_client)
      */
     public function get($path, array $options = [])
     {
-        $options['headers'] = isset($options['headers']) ? $options['headers'] : [];
-        $options['headers']['User-Agent'] = $this->app_client;
+        $options['headers'] = array_merge(
+            ['User-Agent' => $this->app_client],
+            isset($options['headers']) ? $options['headers'] : []
+        );
 
         $response = $this->client->request('GET', $this->host.$this->prefix.$path, $options);
 

diff --git a/tests/Service/BrowserTest.php b/tests/Service/BrowserTest.php
@@ -61,7 +61,23 @@ protected function setUp()
         $this->browser = new Browser($this->client, $this->host, $this->prefix, $this->app_client);
     }
 
-    public function testGet()
+    /**
+     * @return array
+     */
+    public function appClients()
+    {
+        return [
+            [''],
+            ['Override User Agent'],
+        ];
+    }
+
+    /**
+     * @dataProvider appClients
+     *
+     * @param string $app_client
+     */
+    public function testGet($app_client)
     {
         $path = '/foo';
         $params = ['bar' => 'baz'];
@@ -70,6 +86,12 @@ public function testGet()
                 'User-Agent' => $this->app_client,
             ],
         ];
+
+        if ($app_client) {
+            $options['headers']['User-Agent'] = $app_client;
+            $params['headers']['User-Agent'] = $app_client;
+        }
+
         $expected = ['Hello, world!'];
         $content = json_encode($expected);