Add NightBot support and improve performance #3
+26
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
animeshkundu
requested changes
Dec 9, 2017
| videoElement.currentTime = 0; | ||
| videoElement.play(); | ||
| } | ||
| var oldUrl; |
There was a problem hiding this comment.
Not sure, why do you require this.
There was a problem hiding this comment.
I planned to reset video without reloading. But I give up, don't think it's worth spending much time.
You can delete whatever you don't want.
There was a problem hiding this comment.
Okay, I will go ahead an merge it after removing this.
|
Would love to get the above changes in. About the audio url, would you mind being a bit more specific. Would be happy to answer them. Also if I am not replying please feel free to drop an email, update it just now :) |
animeshkundu
approved these changes
Dec 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't maintain this branch anymore. I rewrite it as my extension.
Do you mind share information about audio url? (doc or discuss thread is preferred) That's the only part I don't understand. I rewrite anything else except that. I can make better extension if I understand it.