Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing get/set types, improve documentation #110

Merged
merged 2 commits into from
May 4, 2021

Conversation

rijkvanzanten
Copy link
Contributor

Fixes #109

Also added some inline documentation, in order to have supported editors render useful information inline where the methods are used:

CleanShot 2021-04-29 at 11 01 28@2x

I ran prettier for formatting consistencies sake. There doesn't seem to be an editorconfig or linting setup, so my setup defaulted to tabs w/ 80-column width. Lemme know if you prefer that otherwise.

@coveralls
Copy link

coveralls commented Apr 29, 2021

Pull Request Test Coverage Report for Build 316

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 84.853%

Totals Coverage Status
Change from base Build 314: 0.1%
Covered Lines: 1047
Relevant Lines: 1209

💛 - Coveralls

@animir
Copy link
Owner

animir commented Apr 30, 2021

@rijkvanzanten Wow, that's great 😍 Thank you!

Could you replace all tabs to 4 spaces? Btw, I created an issue for editorconfig #111

@rijkvanzanten
Copy link
Contributor Author

All set!

@animir
Copy link
Owner

animir commented May 4, 2021

@rijkvanzanten 👍

@animir animir merged commit c9feb09 into animir:master May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Runtime options missing in TypeScript definition
3 participants