Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove timeout on deletion of node #146

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

jiddmeye
Copy link

When using the delete function, I noticed that the timeouts are not cleared. This causes the timeout to be executed even if the item was already deleted. If there is already a new item with the same key in the meantime, that one will be removed.

@animir
Copy link
Owner

animir commented Dec 1, 2021

@jiddmeye Great find, thank you!

@animir animir merged commit d0b7302 into animir:master Dec 1, 2021
@animir
Copy link
Owner

animir commented Dec 1, 2021

Published in v2.3.6

@shneor521
Copy link

I spent many hours understanding the strange behavior of my project (I used 2.3.0). In the end, I discovered that this is exactly the bug I have. I upgraded to 2.3.6, and everything works great!
Thanks to @jiddmeye for the finding and the fix!

@jiddmeye jiddmeye deleted the bugfix/remove_timeout_on_delete branch March 21, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants