Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom config and font for funke #121

Open
wants to merge 4 commits into
base: feat/storybook
Choose a base branch
from

Conversation

TimoGlastra
Copy link
Member

Builds on top of #120. Adds custom config for the Funke wallet with custom primary color and fonts. The font setup has been improved in general by loading them in the app config, which pre-loads them and means we don't have to load the fonts on startup.

Paradym wallet still uses Inter, Funke wallet uses Raleway.

@janrtvld Maybe you can help a bit with configuring the theme and colors / sizes for the Funke app. I only configured the primary color now.

Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
@TimoGlastra
Copy link
Member Author

This branch also contains some fixes for #120 . so we either need to merge at the same time, or merge this PR into #120 first

Signed-off-by: Timo Glastra <timo@animo.id>
Comment on lines +59 to +63
fonts: [
'../../node_modules/@expo-google-fonts/raleway/Raleway_400Regular.ttf',
'../../node_modules/@expo-google-fonts/raleway/Raleway_500Medium.ttf',
'../../node_modules/@expo-google-fonts/raleway/Raleway_600SemiBold.ttf',
'../../node_modules/@expo-google-fonts/raleway/Raleway_700Bold.ttf',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually use 'Raleaway' for only the titles and headings. The body font is 'Open sans'.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay will update 👍

declare module 'tamagui' {
// eslint-disable-next-line @typescript-eslint/no-empty-interface
interface TamaguiCustomConfig extends Conf {}
interface TamaguiCustomConfig extends ConfIg {}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will revert

@janrtvld
Copy link

I'll check out the theme/config today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants