Service Provider-specific parameters should be accepted when getting a Request Token

[GoogleCodeExporter]

What steps will reproduce the problem?
1.
I create a provider:
 OAuthProvider provider = new DefaultOAuthProvider(consumer,
                REQUEST_TOKEN_ENDPOINT_URL, ACCESS_TOKEN_ENDPOINT_URL,
                AUTHORIZE_WEBSITE_URL);
where AUTHORIZE_WEBSITE_URL is:
"http://myaccount-nightly.us2.global.ad/userservices-myaccount/myaccount/confirm
_access?us_oauth_method=onestep
that is, it contains an extra parameter

2.
I get a request token
String authorizeRequestTokenUrl = provider.retrieveRequestToken(CALLBACK_URL);

The returned URL is
http://myaccount-nightly.us2.global.ad/userservices-myaccount/myaccount/confirm_
access?us_oauth_method=onestep?oauth_token=51895058-4178-4a89-9ead-6cd969691e47&
oauth_callback=http%3A%2F%2Fmy.domain.com

and it is incorrect, it contains two '?' because
DefaultOAuthProvider.retrieveRequestToken does not check the existence of
'?' in the URL.
3.

What is the expected output? What do you see instead?
DefaultOAuthProvider.retrieveRequestToken should check the existence of
parameters in the URL and if there is one then it should append '&' instead
of '?' as a starter for oauth parameters. 

The OAuth spec 1.0, chapter 6.2.1 states that additional parameters are
accepted so Signpost should support those.


What version of the product are you using? On what operating system?
1.0-SNAPSHOT on Mac OSX


Please provide any additional information below.

Original issue reported on code.google.com by erno.to...@gmail.com on 3 Jun 2009 at 12:54

[GoogleCodeExporter]

Yes. This is a known issue, I explicitly stated on the project frontpage that 
this is
currently unsupported. I'll try to get this fixed this soon.

Original comment by m.kaepp...@gmail.com on 3 Jun 2009 at 1:50

• Changed state: Accepted

[GoogleCodeExporter]

Original comment by m.kaepp...@gmail.com on 5 Jun 2009 at 8:21

[GoogleCodeExporter]

This issue was closed by r39.

Original comment by m.kaepp...@gmail.com on 15 Jun 2009 at 8:09

• Changed state: Fixed