New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update to use pyyaml 6 #340
Conversation
PyYAML 6 dropped support for Python 2.7, which dotbot still supports. |
This might be the reason to drop support for Python 2.7, when our dependencies no longer support it (and upgrading dependencies is the easiest solution to problems like that posted in the OP). |
I advocate for discontinuing support for Python 2.7 due to several reasons:
and, of course
|
I reckon the README already suggests no Python 2: Lines 70 to 71 in 712b30a
Anyways, I would be happy to help out with it too. |
I am not able to install docbot properly via pip on Python 3.11. The reasons is the <6 pyyaml version constraint. pyyaml supported Python 3.11 only recently: yaml/pyyaml@957ae4d. You have to choose to support either of 3.11 or 2.7. I'd vote for supporting 3.11 and dropping EOL 2.7. |
python 2.7 has been EOL for quite some time, and macOS has not shipped it by default either, also all package managers stop shipping packages using py2, so it would be good to just drop it and then prep for the upcoming py3.12 release :) just my two cents. |
I'm on board with this plan to drop Py2 support; will process these recent PRs when I get some free time. |
This was causing install issues with newer versions of Python / setuptools; see yaml/pyyaml#723. Thanks to Rui Chen <rui@chenrui.dev> for reporting this issue in #340.
This was causing install issues with newer versions of Python / setuptools; see yaml/pyyaml#723. Thanks to Rui Chen <rui@chenrui.dev> for reporting this issue in #340.
Thank you for the PR. I didn't just want to remove the version specification altogether; alternative change in b732baf (you're credited in there). Thanks all for your patience. This is included in Dotbot 1.20.0 and released on PyPI. |
relates to Homebrew/homebrew-core#136978
also relates to yaml/pyyaml#723 yaml/pyyaml#601