-
Notifications
You must be signed in to change notification settings - Fork 189
Maintainer Guidelines
Isabel Costa edited this page Feb 1, 2022
·
2 revisions
Make sure contributors are respecting the Contribution Guidelines. If they don't let them know about it: what is missing, what was disrespected?
- When possible get a second opinion before merging.
- Make sure the PR has a link to the issue.
- If you can, let them know why your change request makes sense.
- (nice to have) If you have time, thank them for contributing to the project.
- Make sure that, if the PR changes actual code, to properly test it or wait for someone to confirm the behavior
TL;DR:
- Select "Squash and Merge".
- Edit commit if necessary to follow our style guide and leave the PR id in the message.
Long version:
About merging pull requests (PRs), to keep the project commit history clean, it's important to have all commits from a PR to be squashed when merging. For this you may have to select "Squash and Merge" option:
![Squash and Merge on GitHub](https://user-images.githubusercontent.com/11148726/76369025-06146e80-632a-11ea-922a-c28073539125.png)
If the commit does not follow our Commit Message Style Guide, make sure to ask the contributor to fix it or you can fix it when merging.
![Edit Commit when Merging](https://user-images.githubusercontent.com/11148726/76369362-33155100-632b-11ea-90d1-879dbecfb059.png)
Make sure to always leave the PR identifier, so that we can traceback a commit to a specific PR.
- Home
- AnitaB.org
- Implementation Guide
- Product Roadmap
- How To Contribute
- [Testing]
- GSoC 2021
- GSoC 2022
- GSoC 2023
- Projects