Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup the env BIT and MS backend server #261

Closed
wants to merge 1 commit into from

Conversation

y-martinez
Copy link
Contributor

@y-martinez y-martinez commented Apr 9, 2021

Description

This is the proof of setup the env of project

Partial Fixes: #244

Type of Change:

  • Documentation/Training

How Has This Been Tested?

This is the result successfully of the register

image

This is the result successfully of the login

image

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas

@epicadk
Copy link
Member

epicadk commented Apr 9, 2021

Have you setup mentorship system from @mtreacy002's fork?

@y-martinez
Copy link
Contributor Author

Have you setup mentorship system from @mtreacy002's fork?

The two projects must be running at the same time?

@mtreacy002
Copy link
Member

@y-martinez , you must use local instead of dev as the value inside your Flask_Environment_Config
Screen Shot 2021-04-10 at 10 44 51 am

@y-martinez
Copy link
Contributor Author

@y-martinez , you must use local instead of dev as the value inside your Flask_Environment_Config
Screen Shot 2021-04-10 at 10 44 51 am

But I don't get it, the .env configuration of the mentorship project must the same to this project?

@epicadk
Copy link
Member

epicadk commented Apr 11, 2021

@y-martinez , you must use local instead of dev as the value inside your Flask_Environment_Config
Screen Shot 2021-04-10 at 10 44 51 am

But I don't get it, the .env configuration of the mentorship project must the same to this project?

Hi can you join the BIT open session today? Maybe we can help you out.

@y-martinez
Copy link
Contributor Author

@y-martinez , you must use local instead of dev as the value inside your Flask_Environment_Config
Screen Shot 2021-04-10 at 10 44 51 am

But I don't get it, the .env configuration of the mentorship project must the same to this project?

Hi can you join the BIT open session today? Maybe we can help you out.

Yes sure but, what timezone is the BIT session?

@epicadk
Copy link
Member

epicadk commented Apr 11, 2021

@y-martinez , you must use local instead of dev as the value inside your Flask_Environment_Config
Screen Shot 2021-04-10 at 10 44 51 am

But I don't get it, the .env configuration of the mentorship project must the same to this project?

Hi can you join the BIT open session today? Maybe we can help you out.

Yes sure but, what timezone is the BIT session?

It's at 10:00 am today GMT.

@y-martinez
Copy link
Contributor Author

@y-martinez , you must use local instead of dev as the value inside your Flask_Environment_Config
Screen Shot 2021-04-10 at 10 44 51 am

But I don't get it, the .env configuration of the mentorship project must the same to this project?

Hi can you join the BIT open session today? Maybe we can help you out.

Yes sure but, what timezone is the BIT session?

It's at 10:00 am today GMT.

In 5 hours? well I will need to get up very early 😅 but ok I will try it, right now I have this error in the mentorship system from @mtreacy002's fork

image

@epicadk
Copy link
Member

epicadk commented Apr 11, 2021

@y-martinez
Copy link
Contributor Author

Forget it, I think that I did it, I had to change in branch https://github.com/mtreacy002/mentorship-backend/tree/ms-backend-server of the mentorship project,

image

in the repo instructions, it did not describe this.

This is the result of the registering endpoint using the two projects

This was the result using the BIT project
image

and this was the result using the MS backend server with the @mtreacy002 branch

image

so, I did it 😅 ?

@epicadk
Copy link
Member

epicadk commented Apr 11, 2021

Yes. Good job. 👍🏼

@y-martinez y-martinez changed the title [WIP] Setup the env Setup the env BIT and MS backend server Apr 11, 2021
@y-martinez y-martinez marked this pull request as ready for review April 11, 2021 04:35
@y-martinez
Copy link
Contributor Author

Yes. Good job. 👍🏼

Nice! 😎 well I updated the PR with the proof of setup 👍

@epicadk
Copy link
Member

epicadk commented Apr 11, 2021

Good job. Closing because this won't be merged. Will be accepted for OSH. 👍🏽

@epicadk epicadk closed this Apr 11, 2021
@mtreacy002
Copy link
Member

in the repo instructions, it did not describe this.

@y-martinez , probably you missed this. It is actually mentioned in the setup instruction for BIT backend under step 9 as can be seen below.
image

@mtreacy002
Copy link
Member

so, I did it 😅 ?

Well done @y-martinez 🎉🎉. Don't forget that you need to make sure you've successfully login as per mentioned in the issue #244.

image

So you're halfway there 👍. Just confirm your email and login from swagger UI 😉. Cc @epicadk

@epicadk
Copy link
Member

epicadk commented Apr 11, 2021

so, I did it 😅 ?

Well done @y-martinez 🎉🎉. Don't forget that you need to make sure you've successfully login as per mentioned in the issue #244.

image

So you're halfway there 👍. Just confirm your email and login from swagger UI 😉. Cc @epicadk

Oops yes please do this.

@y-martinez
Copy link
Contributor Author

so, I did it sweat_smile ?

Well done @y-martinez . Don't forget that you need to make sure you've successfully login as per mentioned in the issue #244.

image

So you're halfway there . Just confirm your email and login from swagger UI . Cc @epicadk

Yes I updated the PR with the proof of login successful

@mtreacy002
Copy link
Member

Forget it, I think that I did it, I had to change in branch https://github.com/mtreacy002/mentorship-backend/tree/ms-backend-server of the mentorship project,

image

in the repo instructions, it did not describe this.

Or perhaps you're referring to step 8?
image

@y-martinez
Copy link
Contributor Author

The screenshot in the issue

Forget it, I think that I did it, I had to change in branch https://github.com/mtreacy002/mentorship-backend/tree/ms-backend-server of the mentorship project,

image

in the repo instructions, it did not describe this.

Or perhaps you're referring to step 8?
image

No, I mean the instructions for the configuration of the mentorship-backend project, it is not specified that it was necessary to uncomment those lines.

Do I write a comment with the screenshot of the login successful in the issue #244 ?

@mtreacy002
Copy link
Member

mtreacy002 commented Apr 11, 2021

Do I write a comment with the screenshot of the login successful in the issue #244 ?

@y-martinez , you don't need to, since as long as you refer the issue in this PR description, it'll show up on that issue so mentors can check the pr out to see if it is done or not.

Screen Shot 2021-04-11 at 7 08 35 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: Set up local environment
3 participants