Feat: Issue#27 view user personal details #38

mtreacy002 · 2020-07-12T05:56:01Z

Description

Add feature: View user's personal details

Fixes #27

Type of Change:

Code
User Interface

Code/Quality Assurance Only

New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

login as user
go to My Space -> My Profile page
See Personal Details

Checklist:

My PR follows the style guidelines of this project
I have performed a self-review of my own code or materials

Code/Quality Assurance Only

My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes

mtreacy002 · 2020-07-12T06:00:40Z

Update @anitab-org/bridgeintech-maintainers . Here's the view personal details as per issue #27 . @meenakshi-dhanani . I'm wondering what type of tests are needed for this one as I couldn't see them (tests) being mentioned in the issue's acceptance criteria. Or should it be tackle in a separate issue?

meenakshi-dhanani · 2020-07-12T11:35:40Z

src/myspace/MyPersonalDetails.jsx

+  const [skills, setSkills] = useState(null);
+  const [resumeUrl, setResumeUrl] = useState(null);
+  const [photoUrl, setPhotoUrl] = useState(null);
+


why not just have const [personalDetails, setPersonalDetails] = useState(null);

and set whatever comes in response as the personalDetails?

I don't see the benefit in cluttering with so many use states

@meenakshi-dhanani , I tried your suggestion. Using const [personalDetails, setPersonalDetails] = useState(null) or useState({}) but none of these options get the data out from the response. Here's the screenshot of what I've done.

Do you have any other suggestion?

And here's the result of thee page when rendered (with empty data)

I'll check it out, as a convention if your setter is setPersonalDetails then your variable would be personalDetails and not personal_details

Hi @meenakshi-dhanani . I tried with the correct naming convention. Still didn't work (cannot get data out of fetch using setPersonalDetails)

using null

using {}

Do you have any other suggestion?

Check the Todo file in this sandbox - https://codesandbox.io/s/xenodochial-rain-fet6s?file=/src/Todo.js

Here, I am not setting time and title separately.

@meenakshi-dhanani . Have you try it using the fetch from API? Does it work on your end? I've pushed the latest code with your alternative solution in case you want to give it a try. Let me know if it works for you. If you want to catch up for troubleshoot, I'm available. Ta

mtreacy002

Update @meenakshi-dhanani . Can you give other suggestion? naming convention doesn't solve the issue of not able getting data out of fetch using dict or null. So far it only works when data is set individually inside fetch as what I 've done in the PR.

mtreacy002 · 2020-07-14T01:32:44Z

src/myspace/MyPersonalDetails.jsx

+  const [skills, setSkills] = useState(null);
+  const [resumeUrl, setResumeUrl] = useState(null);
+  const [photoUrl, setPhotoUrl] = useState(null);
+


Hi @meenakshi-dhanani . I tried with the correct naming convention. Still didn't work (cannot get data out of fetch using setPersonalDetails)

using null

using {}

Do you have any other suggestion?

meenakshi-dhanani · 2020-07-15T10:09:04Z

src/myspace/PersonalDetails.jsx

+  // const [name, setName] = useState(null);
+  // const [ircId, setIrcId] = useState(null);
+  // const [mentor, setMentor] = useState(null);
+  // const [mentee, setMentee] = useState(null);


Please even while trying no comments. If something doesn't work it's never lost. You can always get it from the previous commit

got it. fixed now.

mtreacy002 · 2020-07-17T00:43:31Z

Update @meenakshi-dhanani . I just realized what's missing. I've now applied useEffect for fetch and it works (setting the data using dict for fetch). Sorry for the hassle. Please re-review.

mtreacy002 · 2020-07-17T01:26:38Z

@meenakshi-dhanani. I'm going to open a new branch for testing this view user personal details. Since I'm going to carry this PR code across, I'm going to merge the 6 commits here into one to avoid rebase hell. I'll force pushed the single commit soon.

mtreacy002 · 2020-07-17T14:29:03Z

Update @meenakshi-dhanani . I've just pushed the latest code change as we discussed just now in your office hour. Please re-review. 😉

meenakshi-dhanani · 2020-07-17T15:08:14Z

src/myspace/PersonalDetails.jsx

+  const requestPersonalDetails = {
+    method: "GET",
+    headers: {
+      "Authorization": `Bearer ${Cookies.get("access_token")}`,


@mtreacy002 sorry I did not realize the token comes from the cookie. We are creating the AuthContext as a wrapper for any auth related details. If we start getting access_token from cookie directly, every other component that we make will have this same logic. It is the responsibility of the context, to abstract these details out.

Can you send the access_token also from the provider, and use it here?

done. It's now added to AuthContext and used in request header from that. 👍

PR#38 rename files/routes and refactor set data using dict PR#38 apply useEffect to get data using dict PR#38 remove comments PR#38 protect personal detail page before login PR#38 Fix Navbar toggle issue after user logout PR#38 remove buttons from personal details form and fix navbar PR#38 add token to AuthContext PR#38 remove unused import PR#38 Fix navbar toggle login logout from profile pages

meenakshi-dhanani · 2020-07-18T10:41:36Z

@ramitsawhney27 I have reviewed the code, I think @foongminwong might not be available, could you test this at your end and if all looks good maybe approve?

mtreacy002 self-assigned this Jul 12, 2020

mtreacy002 added Category: Coding Changes to code base or refactored code that doesn't fix a bug. Category: User Interface Improvements or additions to design. Program: GSOC Related to work completed during the Google Summer of Code Program. labels Jul 12, 2020

mtreacy002 added this to the GSoC: Coding Phase II milestone Jul 12, 2020

meenakshi-dhanani reviewed Jul 12, 2020

View reviewed changes

mtreacy002 requested a review from meenakshi-dhanani July 12, 2020 15:10

mtreacy002 commented Jul 14, 2020

View reviewed changes

mtreacy002 force-pushed the issue#27-view-user-personal-details branch from 255aed8 to a250273 Compare July 14, 2020 23:51

meenakshi-dhanani reviewed Jul 15, 2020

View reviewed changes

mtreacy002 requested review from meenakshi-dhanani and foongminwong July 17, 2020 01:05

mtreacy002 changed the title ~~WIP | Feat: Issue#27 view user personal details~~ Feat: Issue#27 view user personal details Jul 17, 2020

mtreacy002 force-pushed the issue#27-view-user-personal-details branch from a76b742 to 16162aa Compare July 17, 2020 01:30

meenakshi-dhanani reviewed Jul 17, 2020

View reviewed changes

mtreacy002 force-pushed the issue#27-view-user-personal-details branch from c0550f5 to 2e2f90a Compare July 18, 2020 00:26

meenakshi-dhanani approved these changes Jul 18, 2020

View reviewed changes

ramitsawhney27 approved these changes Jul 19, 2020

View reviewed changes

meenakshi-dhanani merged commit e25d9a4 into anitab-org:develop Jul 19, 2020

mtreacy002 deleted the issue#27-view-user-personal-details branch September 12, 2020 00:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat: Issue#27 view user personal details #38

Feat: Issue#27 view user personal details #38

mtreacy002 commented Jul 12, 2020 •

edited

Loading

mtreacy002 commented Jul 12, 2020

meenakshi-dhanani Jul 12, 2020

mtreacy002 Jul 12, 2020

mtreacy002 Jul 12, 2020

meenakshi-dhanani Jul 13, 2020

mtreacy002 Jul 14, 2020

meenakshi-dhanani Jul 14, 2020

mtreacy002 Jul 15, 2020

mtreacy002 left a comment

mtreacy002 Jul 14, 2020

meenakshi-dhanani Jul 15, 2020

mtreacy002 Jul 17, 2020

mtreacy002 commented Jul 17, 2020

mtreacy002 commented Jul 17, 2020 •

edited

Loading

mtreacy002 commented Jul 17, 2020

meenakshi-dhanani Jul 17, 2020

mtreacy002 Jul 17, 2020

meenakshi-dhanani commented Jul 18, 2020

Feat: Issue#27 view user personal details #38

Feat: Issue#27 view user personal details #38

Conversation

mtreacy002 commented Jul 12, 2020 • edited Loading

Description

Type of Change:

How Has This Been Tested?

Checklist:

mtreacy002 commented Jul 12, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mtreacy002 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mtreacy002 commented Jul 17, 2020

mtreacy002 commented Jul 17, 2020 • edited Loading

mtreacy002 commented Jul 17, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

meenakshi-dhanani commented Jul 18, 2020

mtreacy002 commented Jul 12, 2020 •

edited

Loading

mtreacy002 commented Jul 17, 2020 •

edited

Loading