Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: View members list #59

Merged
merged 2 commits into from
Aug 10, 2020
Merged

Feat: View members list #59

merged 2 commits into from
Aug 10, 2020

Conversation

mtreacy002
Copy link
Member

@mtreacy002 mtreacy002 commented Jul 30, 2020 •
edited
Loading

Description

Allow user to see list of members

Fixes #58

Type of Change:

  • Code
  • User Interface

Code/Quality Assurance Only

  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

  • run the application
  • with user not logged-in go to Members page
  • see login form
  • login as a user
  • now go to Members page
  • see members list. (Note make sure you have created at least 3 verified users and 1 non verified users. The list should contain the 2 verified users beside the logged-in user)

Screen Shot 2020-07-30 at 11 11 37 pm

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

Code/Quality Assurance Only

  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@mtreacy002 mtreacy002 self-assigned this Jul 30, 2020
@mtreacy002 mtreacy002 added Category: Coding Changes to code base or refactored code that doesn't fix a bug. Category: User Interface Improvements or additions to design. Program: GSOC Related to work completed during the Google Summer of Code Program. labels Jul 30, 2020
@mtreacy002 mtreacy002 added this to the GSoC: Coding Phase II milestone Jul 30, 2020
@mtreacy002
Copy link
Member Author

Update @anitab-org/bridgeintech-maintainers . here's the PR for View members list. Please review when you have time. Thanks

@mtreacy002 mtreacy002 force-pushed the view-members-list branch 2 times, most recently from f6e0d5a to f21e390 Compare July 30, 2020 13:13
ramitsawhney27
ramitsawhney27 reviewed Jul 31, 2020
View reviewed changes
src/members/Members.jsx
</thead>
<tbody>
{members.map((member) => (
<tr key={member.id}>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to have a loop over member attributes rather than specifically writing member.attribute? I just feel that's more generic and scalable.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmm... I'm not sure tbh. I'll discuss this with @meenakshi-dhanani in her office hour tonight.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although, @ramitsawhney27 . It might not be straight forward to loop over attrributes of member as the Program Completed column does not come from the member data within the members list, but abstracted from all programs that the member's would've done by the time logged-in user view the members list.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's okay I think. It's readable. You can use Object.values() to iterate over the values in the object. But I feel this is fine. And like Maya mentioned, there are two things that don't come from the member list.

@mtreacy002 mtreacy002 force-pushed the view-members-list branch 4 times, most recently from 2831716 to 65505e6 Compare August 2, 2020 14:06
@mtreacy002
Feat Update user additional info for Timezone
7c87442 
add default value to is_organization_rep

Fix if else and fetch bug

Fix POST and PUT additional info

Fix bug defaultChecked checkbox is_organization_rep

fix bug timezone not selected

Refactor api requests to PUT for both create and update additional info
@meenakshi-dhanani
Copy link
Contributor

Displaying need_mentoring and available_to_mentor as booleans True and False is too technical. We could have labels for member profiles. But I'm fine with this for now as MVP. We can make it beautiful later, with some profile icon maybe

@mtreacy002
Copy link
Member Author

Update @anitab-org/bridgeintech-maintainers . I've just force pushed the fix on constant SERVICE_UNAVAILABLE_ERROR.

@mtreacy002
Feat: View members list
5ab20f7 
Add availabilities column

add tba on Program completed and Current Availability columns

Fix service unavailable constant
foongminwong
foongminwong approved these changes Aug 9, 2020
View reviewed changes
Copy link

@foongminwong foongminwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes made in this PR were tested locally. Following are the results:

  1. Code review - Done

  2. All possible responses were tested as below:

    • Test PR 59 - View members list
      Screenshot/gif/url:

      test-bit-web-pr-59-user-list-1

      Expected Result: As a user, I should be able to view members list.
      Actual Result: Same as expected.

  3. OS Version: Windows 10

@meenakshi-dhanani meenakshi-dhanani merged commit 3ba3f1b into anitab-org:develop Aug 10, 2020
@mtreacy002 mtreacy002 deleted the view-members-list branch September 12, 2020 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meenakshi-dhanani meenakshi-dhanani meenakshi-dhanani approved these changes

@foongminwong foongminwong foongminwong approved these changes

@ramitsawhney27 ramitsawhney27 Awaiting requested review from ramitsawhney27

Assignees

@mtreacy002 mtreacy002

Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Category: User Interface Improvements or additions to design. Program: GSOC Related to work completed during the Google Summer of Code Program.
Projects
None yet
Milestone
GSoC: Coding Phase II
Development

Successfully merging this pull request may close these issues.

Feat: View Members List
4 participants
@mtreacy002 @meenakshi-dhanani @foongminwong @ramitsawhney27