Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Issue60 view other member details #62

Merged

Conversation

mtreacy002
Copy link
Member

@mtreacy002 mtreacy002 commented Aug 6, 2020

Description

Allow user to view other member's personal details

Fixes #60

Type of Change:

  • Code
  • User Interface

Code/Quality Assurance Only

  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

  • Login as a user
  • Go to Members and select a member from the list of users
  • See member details

Screen Shot 2020-08-08 at 12 57 27 am

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas

Code/Quality Assurance Only

  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@mtreacy002 mtreacy002 self-assigned this Aug 6, 2020
@mtreacy002 mtreacy002 added Category: Coding Changes to code base or refactored code that doesn't fix a bug. Program: GSOC Related to work completed during the Google Summer of Code Program. labels Aug 6, 2020
@mtreacy002
Copy link
Member Author

@meenakshi-dhanani . I'm having trouble trying to get the Member Profile page to render the member details. The problem could be because of the page is under Protected page under another Protected page (Members). I've pushed the code I have so far. Can you please give me a hint how to troubleshoot this? Thanks

@mtreacy002 mtreacy002 force-pushed the issue60-view-other-member-details branch from ad73f73 to fc841bb Compare August 7, 2020 15:02
@mtreacy002 mtreacy002 changed the title WIP | Feat: Issue60 view other member details Feat: Issue60 view other member details Aug 7, 2020
@mtreacy002 mtreacy002 requested review from meenakshi-dhanani and a team August 7, 2020 15:04
@mtreacy002
Copy link
Member Author

Update @meenakshi-dhanani and @anitab-org/bridgeintech-maintainers. I've pushed the lateest changes. This PR is now ready to be reviewed. Please check it out when you have time. Thanks

@mtreacy002
Copy link
Member Author

@ramitsawhney27 . In this View other member details UI, I do not use GET /users/{user_id} endpoint to get the member details. In fact, I directly pick user using the mapping on list of users returned from the GET /users requests from the Members page. Therefor, @meenakshi-dhanani and I thought we might not need the GET /users/{user_id} endpoint at the backend (PR#99. anymore, unless we have other case where we are going to use the GET /users/{user_id} endpoint.
@isabelcosta, Is there any other case where we use this endpoint in the Mentorship System that you are aware of (either from Android UI features or backend logic probably) beside viewing user details?

@mtreacy002 mtreacy002 force-pushed the issue60-view-other-member-details branch from fc841bb to 1aba46e Compare August 8, 2020 01:01
@meenakshi-dhanani
Copy link
Contributor

LGTM! Just would want to rename the component to Member

fix handlelick

fix redirecting to member detail

Fix field type to non input

Remove console.log
@mtreacy002 mtreacy002 force-pushed the issue60-view-other-member-details branch from 1aba46e to 3941645 Compare August 10, 2020 23:36
@mtreacy002
Copy link
Member Author

Update @meenakshi-dhanani and @anitab-org/bridgeintech-maintainers. I've resolved the conflict. Can you please re-review this PR? Thanks

Copy link

@foongminwong foongminwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes made in this PR were tested locally. Following are the results:

  1. Code review - Done

  2. All possible responses were tested as below:

    • Test PR 62 - View other member details under Members page
      Screenshot/gif/url:

      test-bit-web-pr-62

      Expected Result: As a user, I should be able to view other member details on the BIT website.
      Actual Result: Same as expected.

  3. OS Version: Windows 10

@foongminwong foongminwong merged commit 2569479 into anitab-org:develop Aug 11, 2020
@mtreacy002 mtreacy002 deleted the issue60-view-other-member-details branch September 12, 2020 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Program: GSOC Related to work completed during the Google Summer of Code Program.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: View Other Member details
3 participants