Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a visual representation of our Open Source workflow #3

Open
1 task
isabelcosta opened this issue May 21, 2020 · 29 comments · May be fixed by #5
Open
1 task

Create a visual representation of our Open Source workflow #3

isabelcosta opened this issue May 21, 2020 · 29 comments · May be fixed by #5
Assignees
Labels
Category: Documentation/Training Improvements or additions to documentation.

Comments

@isabelcosta
Copy link
Member

isabelcosta commented May 21, 2020

Problem

As we evolve as a community, we are evolving our open source workflow. Currently we have been trying to add a QA testing step to how we handle pull requests, and this is not yet visually represented. I think this could clear up confusion from new and current contributors.

In the past, we had this open source workflow: http://systers.io/open-source-workflow

Today we have a specific way of assigning labels to define the status of PRs and issues. We want to have this visually represented.

To help understand some of our workflow currently being followed, check our Open Source teams guide.

Tasks

  • Create a visual representaiton that explains ourcurrent open source wokflow.
@isabelcosta isabelcosta added the Category: Documentation/Training Improvements or additions to documentation. label May 21, 2020
@mitchell-frost
Copy link

I am new here. Can I work on this to get started?

@isabelcosta
Copy link
Member Author

@mitchell-frost sure you can :) Do you understand what this is about and where you can find information to build this representation?

@mitchell-frost
Copy link

@isabelcosta I am actually not sure where to start. Any help shall be appreciated!

@isabelcosta
Copy link
Member Author

@mitchell-frost no problem, I would start by looking at the document I mention in the issue description - Open Source teams guide - so you understand the label system we use.

For example, these are some of the things we'd like to see in the representation:
workflow since someone creates an issue until a PR of that issue is merged. We use some labels to manage the PRs current status. For example, after we have 2 minimum code reviews we add the "Status: needs Testing" label. After at least someone reports a tests done to the PR, if no issue arises, we add label "Status: Ready to Merge" so that maintainers know they can merge the PR.

You can also see a past workflow representation in the issue description. Do you understand this is not a coding issue but a documentation one? The result of this may get into our https://anitab-org.github.io website, and general documentation in this repository. This is something to guide our current and future contributors.

Are you on our Zulip? If not i would advise you to join, you may understand some of our workflow discussions there.

👉 https://anitab-org.zulipchat.com/

@mitchell-frost
Copy link

@isabelcosta thanks! I will start working on it and I understand that it's a documentation issue.

@isabelcosta
Copy link
Member Author

@mitchell-frost Feel free to use GitHub comments or Zulip messages or an office hour of mine to discuss this and ask more questions. I am having an office hour today at 23h (Lisbon timezone) :)

@isabelcosta
Copy link
Member Author

@mitchell-frost Any updates? Do you need any help?

@mitchell-frost
Copy link

I am working on another issue as well. I will keep you updated about the progress @isabelcosta

@isabelcosta
Copy link
Member Author

@mitchell-frost its better to focus on one issue at a time. Do you mind if I make this available again, until you are available again? This is a high priority issue, because there is a lot of confusion in the community with what we are doing in the community

@nandini45
Copy link
Member

@isabelcosta she is already working on a issue in anitab-org.github.io open source website (anitab-org/anitab-org.github.io#42).
its better to make this issue available again.
and i agree we do need to setup the contribution guidelines again for all the repository especially for newcomers and other contributions

@isabelcosta
Copy link
Member Author

@nandini45 thank you for the update, I will make this available again :)

@isabelcosta isabelcosta added the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label May 30, 2020
@rpattath
Copy link
Member

Workflow requirements:

When the PR is in Status: Needs Review - 2 minimum approved code reviews.

When the PR is in Status: Needs Testing: minimum 1 tester has to test locally and report it as a comment on the PR.

Tester says:
→ success → “Status: Ready to Merge”
→ failure → “Status: Needs Review”

@mitchell-frost
Copy link

@isabelcosta @nandini45 Apologies about the confusion. I am new here. I will try not to take up two issues at once.

@isabelcosta isabelcosta removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Jun 1, 2020
@isabelcosta
Copy link
Member Author

@mitchell-frost no worries at all! We prefer for contributors to work on one issue at a time so that others can take on other issues. Now you know :) I hope you are enjoying working on the other issue.

@rpattath rpattath linked a pull request Jun 6, 2020 that will close this issue
@mayburgos
Copy link

@rpattath I can work on this. :)

@rpattath
Copy link
Member

Thank you @mayburgos ! Let me know if I could be of any help :)

@isabelcosta
Copy link
Member Author

@rpattath I talked about this in the Content Open Session today, and @mayburgos agreed to help you with the visual representation, your PR is still going to be part of this work :)

@rpattath
Copy link
Member

@isabelcosta sounds like a great plan !

@mayburgos let me know if you want me to come up with a visual representation for you to review, or if you are coming up with one I would be more than happy to look at it.

@rpattath
Copy link
Member

@mayburgos @isabelcosta please release me from this Issue. I think integration test automation is a very pressing issue for qa-team as of now. I would like to focus on that. I am sorry.

@isabelcosta
Copy link
Member Author

@rpattath no need to apologize. We completely understand, and you updated us, that's all we need :)

@isabelcosta isabelcosta added the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Nov 21, 2020
@noobkid2411
Copy link

noobkid2411 commented Jan 19, 2021

  • Hi, @isabelcosta this is Sonakshi. I am new here and would very much like to contribute to this issue.I hope I can help in resolving it. Can I get started on this? Any help would be appreciated.

@devifeoma
Copy link

Hi @isabelcosta, I’m Judith and I would like to contribute to this. I await your response.

@isabelcosta
Copy link
Member Author

@noobkid2411 are you still interested in working on this? If yes, I'll assign to you if not, no problem, I'll assign to @devifeoma :)

@devifeoma
Copy link

devifeoma commented Feb 9, 2021 via email

@noobkid2411
Copy link

@isabelcosta @devifeoma yeah I'm still interested ,I'd like to start on this issue.

@isabelcosta
Copy link
Member Author

cool will assign it to you @noobkid2411 :)

@isabelcosta
Copy link
Member Author

@devifeoma we have another project with a documentation issue, if you'd like to work on it, leave a comment and I will assign it to you :)
Issue: anitab-org/anitab-forms-web#71

@isabelcosta isabelcosta removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Feb 10, 2021
@devifeoma
Copy link

devifeoma commented Feb 10, 2021 via email

@devifeoma
Copy link

devifeoma commented Feb 10, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Documentation/Training Improvements or additions to documentation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants