Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create UI_for_relation_request_email.md #873

Closed
wants to merge 2 commits into from

Conversation

titiksha01
Copy link

@titiksha01 titiksha01 commented Sep 16, 2020

Description

Added a mock so that i can get the reviews and proceed to code.

Fixes #770

Type of Change:

  • User Interface

Mock

RelationRequestUI

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

@codecov
Copy link

codecov bot commented Sep 16, 2020

Codecov Report

Merging #873 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #873   +/-   ##
========================================
  Coverage    95.99%   95.99%           
========================================
  Files           96       96           
  Lines         5287     5287           
========================================
  Hits          5075     5075           
  Misses         212      212           

Copy link
Member

@gaurivn gaurivn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The note sent by the mentee in this case is only Hi and export the figma design to png and place just the screenshot here instead of the figma link. And the "Take Action" button is not necessarily needed. Just button for "Login" would do so the mentor can see the notification and act accordingly.

@titiksha01
Copy link
Author

titiksha01 commented Sep 17, 2020

The note sent by the mentee in this case is only Hi and export the figma design to png and place just the screenshot here instead of the figma link. And the "Take Action" button is not necessarily needed. Just button for "Login" would do so the mentor can see the notification and act accordingly.

Okay i'll make the necessary changes. Do i have to upload the png separately or in the md file itself ?

Mock-up for the UI pf relation request email
@titiksha01
Copy link
Author

@gaurivn Pls see if it's correct now and guide me...

Copy link
Member

@gaurivn gaurivn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you, I'll ask @isabelcosta for review/ more insight.

@vj-codes vj-codes added Status: Needs Review PR needs an additional review or a maintainer's review. First Timers Only Good for newcomers. labels Nov 3, 2020
@isabelcosta
Copy link
Member

isabelcosta commented Feb 18, 2021

@titiksha01 thank you for contributing for OSH!
We will close the issue as we're going discuss designs with new community design ambassadors. I will add this PR to our Wiki :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First Timers Only Good for newcomers. Status: Needs Review PR needs an additional review or a maintainer's review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design UI for Mentorship relation request
4 participants