Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

Add links to Terms, Policy and CoC on Sign Up screen #60

Closed
1 of 3 tasks
isabelcosta opened this issue May 10, 2020 · 30 comments · Fixed by #103
Closed
1 of 3 tasks

Add links to Terms, Policy and CoC on Sign Up screen #60

isabelcosta opened this issue May 10, 2020 · 30 comments · Fixed by #103
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Category: User Interface Improvements or additions to design. First Timers Only Good for newcomers. Type: Enhancement New feature or request.

Comments

@isabelcosta
Copy link
Member

isabelcosta commented May 10, 2020

Description

As a user of the system,
I need to have links to terms and conditions on Register screen
so that I can be aware of Terms of use, Code of Conduct and Privacy Policy.

On Registration Screen we need to have a proper text with the Terms and Conditions check box.

Text:

"By checking this box, I affirm that I have read and accept to be bound by the AnitaB.org Code of Conduct, Terms, and Privacy Policy. Further, I consent to the use of my information for the stated purpose."

Links to add:

Code of Conduct: https://ghc.anitab.org/code-of-conduct/
Terms of use: https://anitab.org/terms-of-use/
Privacy Policy: https://anitab.org/privacy-policy/

Screenshots of the issue

Android version:

image

Flutter current version:

image

Acceptance Criteria

Update [Required]

  • Add links to Terms and Conditions, Code of Conduct and Privacy Policy on Sign Up screen

Definition of Done

  • All of the required items are completed.
  • Approval by 1 mentor.

Estimation

🤷‍♀️

@isabelcosta isabelcosta added Type: Enhancement New feature or request. First Timers Only Good for newcomers. Status: Available Issue was approved and available to claim or abandoned for over 3 days. Category: Coding Changes to code base or refactored code that doesn't fix a bug. Category: User Interface Improvements or additions to design. labels May 10, 2020
@isabelcosta
Copy link
Member Author

@bartekpacia @techno-disaster let's leave this to a newcomer, I have no idea the complexity of this, but with your guidance, I feel a newcomer could do this

@techno-disaster
Copy link
Contributor

@bartekpacia @techno-disaster let's leave this to a newcomer, I have no idea the complexity of this, but with your guidance, I feel a newcomer could do this

yep, looks easy. Lets see if anyone picks it up

@techno-disaster
Copy link
Contributor

@bartekpacia @techno-disaster let's leave this to a newcomer, I have no idea the complexity of this, but with your guidance, I feel a newcomer could do this

yep, looks easy. Lets see if anyone picks it up

unless that also requires bloc implementation. 🤦. Will have to check.

@ghost
Copy link

ghost commented May 13, 2020

Hey @isabelcosta !
I'm Mahe. Can I please try resolving this issue?

@techno-disaster
Copy link
Contributor

@Mahekhan sure. assigned it to you

@techno-disaster techno-disaster assigned ghost May 13, 2020
@techno-disaster techno-disaster removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label May 13, 2020
@ghost
Copy link

ghost commented May 14, 2020

Hey @techno-disaster !
I tried following the step by step instructions given here: https://github.com/anitab-org/mentorship-flutter
After installing Flutter SDK and Android SDK, I cloned the mentorship-flutter repository on my system. I opened it on my external IDE (ATOM). I switched to the beta using 'flutter channel beta' command.
When I then give the 'flutter run' command in the flutter console, I get this error;

flutter

But, when I check the contents of the mentorship-flutter repository, the pubspec.yaml file is already there.
here;
atom

@techno-disaster
Copy link
Contributor

@Mahekhan cd into the app directory

@ghost
Copy link

ghost commented May 14, 2020

Yes, thankyou.

@ghost
Copy link

ghost commented May 14, 2020

Yayy! I was finally able to run the flutter app on my system.
mentorship-flutter
It might not be a big achievement, but I am just glad I didn't give up midway and finally got the app running.

@ghost
Copy link

ghost commented May 14, 2020

Now, I myself can see the issue mentioned in the description by @isabelcosta .

@ghost
Copy link

ghost commented May 14, 2020

I think it's the register_screen.dart file in the register folder of the repository that would require the changes. Am I correct, @techno-disaster ?

@ghost
Copy link

ghost commented May 14, 2020

I was googling how to add hyperlinks to text in dart files.
So that I could convert the phrases; Code of Conduct, Terms, and Privacy Policy; into hyperlinks.

@techno-disaster
Copy link
Contributor

I think it's the register_screen.dart file in the register folder of the repository that would require the changes. Am I correct, @techno-disaster ?

yes @Mahekhan . Great work until now, keep it up 👍

@isabelcosta
Copy link
Member Author

@Mahekhan great to see @techno-disaster is helping you out :) Excited to see you working on this issue 🤗

@techno-disaster
Copy link
Contributor

@Mahekhan we have already used url_launcher in the project. You can refer to this stackoverflow link incase you are stuck

@ghost
Copy link

ghost commented May 15, 2020

Hey, @techno-disaster !
I was able to convert the desired pieces of text into hyperlinks. I used 'GestureDetector' widget.
yay
When clicked, the hyperlinks cause browser to open those respective webpages.
yay2
But now the texts is getting overflowed because I removed the 'Flexible' widget.

@techno-disaster
Copy link
Contributor

@Mahekhan Try using Richtext. All the widgets you will need are already there in the stack overflow link i commented earlier

@ghost
Copy link

ghost commented May 17, 2020

Hey, @techno-disaster ! Instead of using GestureDetector, I now used RichText ; like you told me to.
But, I am unable to fix the text overflow issue. The stackoverflow link you provided, and many others I searched, none of them helped me.
I tried wrapping the row using 'Wrap', but to no avail.

@ghost
Copy link

ghost commented May 17, 2020

I tried using Expanded and Flexible too.

@ghost
Copy link

ghost commented May 17, 2020

Please guide me some more.

@ghost
Copy link

ghost commented May 17, 2020

Okay, It's done!!!!! <3

@ghost
Copy link

ghost commented May 17, 2020

final_mentorship

@techno-disaster
Copy link
Contributor

Great work figuring it out yourself @Mahekhan . was busy so couldn't help you earlier but congrats 💯 Next steps: make a PR :)

@ghost
Copy link

ghost commented May 17, 2020

Hey, @techno-disaster.

I improved it a bit.
Earlier the check box was not aligned with the text.
Now, it is!
kardala

@ghost
Copy link

ghost commented May 17, 2020

@techno-disaster , would you please help with making a PR?
I haven't done it before.

@techno-disaster
Copy link
Contributor

@Mahekhan sure, first push your local changes to your forked github repo, then head on over to pull requests, click "New Pull Request". Select "compare across forks" and select your fork, then click "create pull request" . A template should load up for you. Make the required changes in the template, and click Create Request and you are done :). Feel free to ping me if you get stuck in between.

@ghost ghost mentioned this issue May 17, 2020
@ghost
Copy link

ghost commented May 17, 2020

Done. Made my first PR!
Please tell me what you think of it.

@techno-disaster
Copy link
Contributor

@techno-disaster, hey! Please review my PR. :)

Yes @Mahekhan , working on it. Need to make sure everything is right

@isabelcosta
Copy link
Member Author

For next person that picks this up, the PR #73 was almost done, so you can continue this work on your PR :)

@techno-disaster techno-disaster mentioned this issue Jun 11, 2020
4 tasks
@techno-disaster
Copy link
Contributor

Moved to #97

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Category: User Interface Improvements or additions to design. First Timers Only Good for newcomers. Type: Enhancement New feature or request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants