Add a cancel button to the “change password” alert box.

[HaripriyaB]

Description

As a user, I need a cancel button on change password alert box which can take me back if I prefer not to change my password.

Screenshots of the issue

Acceptance Criteria

• Include a cancel button left to submit button

Definition of Done

• All of the required items are completed.
• Approval by 1 mentor.

Estimation

1 hour

[isabelcosta]

@HaripriyaB 👏 👏 👏 very good issue description!

[techno-disaster]

@anitab-org/mentorship-flutter-maintainers-1 can i work on this?

[bartekpacia]

I think this would be a good First timers issue because it's relatively easy. (And if no first timer decides to work on this in, say, a week, then it could be assigned to @techno-disaster )

[techno-disaster]

I think this would be a good First timers issue because it's relatively easy. (And if no first timer decides to work on this in, say, a week, then it could be assigned to @techno-disaster )

makes sense, i wish too see new people start contributing soon too.

[ghost]

Can I try working on this, please? @isabelcosta , @bartekpacia

[HaripriyaB]

sure @Mahekhan assigning to you.

[ghost]

Thankyou, @HaripriyaB !

[ghost]

@bartekpacia , @HaripriyaB , @isabelcosta :

Did it! Yayyyyyyyyyyyy!!!!! <3 :)
On clicking 'Cancel', the dialog box closes and the changes to password are not saved.

[HaripriyaB]

@Mahekhan great you did it! 🥇
Now can you issue a Pull Request mentioning this issue number #64 ?

[ghost]

Hey, @HaripriyaB !
I am new to git and GitHub.
I made a mistake, instead of making a PR, I made a commit.
How do I undo the commit?

[ghost]

Okay. I reverted the commit.

[techno-disaster]

looks like i accidentally created a double of this at #76 . will change it to confirm password field issue only

[techno-disaster]

also @Mahekhan sorry but this is a first timers only so you can't work on it. @HaripriyaB please check if a contributor has a PR open or merged before assigning them to a first timer

[HaripriyaB]

also @Mahekhan sorry but this is a first timers only so you can't work on it. @HaripriyaB please check if a contributor has a PR open or merged before assigning them to a first timer

oh that was my mistake. sorry about that!

[ghost]

@anitab-org/mentorship-flutter-maintainers-1 can i work on this?

Hey, @techno-disaster ! Funny how you didn't see this was a first-timer-only issue when you begged @bartekpacia to assign it to you 8 days ago.

[ghost]

I think this would be a good First timers issue because it's relatively easy. (And if no first timer decides to work on this in, say, a week, then it could be assigned to @techno-disaster )

@techno-disaster , Even funnier that had I not requested to be assigned yesterday, this issue would have been assigned to you. And surely if we keep first timer aside, I am more deserving of this issue than you. You, who according to what your profile says, is a 'Pro'.
I'll tell you what else you are, you are clever, greedy, cunning, and ambitious.
You took three days to respond to my comments about my previous PR. You won't approve it and find faults in it, when there are none to be found.
But today, when you had to unassign me, you were so quick to respond. Didn't take you three days this time!
And congratulations to the maintainers @isabelcosta and @bartekpacia for always being absent and letting this clever, greedy person control everything.
This was my first contributing experience, you people could have been encouraging and if not that you could atleast have been just.
Wow, AnitaB.org, much about 'fairness' in tech and inclusion of women in technology!

[techno-disaster]

I think this would be a good First timers issue because it's relatively easy. (And if no first timer decides to work on this in, say, a week, then it could be assigned to @techno-disaster )

@techno-disaster , Even funnier that had I not requested to be assigned yesterday, this issue would have been assigned to you. And surely if we keep first timer aside, I am more deserving of this issue than you. You, who according to what your profile says, is a 'Pro'.

I am sorry, but I only "asked" @bartekpacia if I could work on it, we did not have a First timer badge on the issue at that time. I have no intention of working on this PR as i already have a issue assigned to me (#67).
The "Pro" is just a "Github Education" badge and i have never flexed about it.

I'll tell you what else you are, you are clever, greedy, cunning, and ambitious.
You took three days to respond to my comments about my previous PR. You won't approve it and find faults in it, when there are none to be found.
But today, when you had to unassign me, you were so quick to respond. Didn't take you three days this time!

Reveiwing PRs takes more time than closing a PR/issue or unassigning someone. PR reviews can extend upto a week. It's good that you think there are no errors in your PR, but as a repo maintainer i have to make sure before i merge it.
Take a look at #57 #66 #69 #71 , these are older PR than your and are still waiting testing or reviewing.

And congratulations to the maintainers @isabelcosta and @bartekpacia for always being absent and letting this clever, greedy person control everything.

Nothing is controlled by a single person alone here, not sure what you mean by this :/

This was my first contributing experience, you people could have been encouraging and if not that you could atleast have been just.
Wow, AnitaB.org, much about 'fairness' in tech and inclusion of women in technology!

By the way thanks for all the nice things you said about me :)
Sorry if I messed up your "contributing experience" .
cc : @mayburgos @annabauza @isabelcosta Please look into this, I'm pretty sure i did everything according to the rules

[ghost]

@techno-disaster
Yes. You did ruin my first contributing experience.
Why did you have to unassign me when I had already invested time and solved the issue?
Sure you wouldn't have been so careful about only a first timer getting this issue assigned to them, had I not requested assignment yesterday and YOU would have been assigned to the issue.

[ghost]

Can you not imagine how discouraging it is when you are very new to open source contribution, you learn a new skill (flutter in this case) to solve issues for your favourite organization, you put in time and effort to solve an issue, you are excited about making a successful PR, and then you suddenly get unassigned!

[ghost]

@techno-disaster
You are the maintainer here, you could have been kinder to me and not unassigned and let me work on this issue!
I am so new to this, I am as good as a first timer!

[techno-disaster]

@techno-disaster
Yes. You did ruin my first contributing experience.
Why did you have to unassign me when I had already invested time and solved the issue?
Sure you wouldn't have been so careful about only a first timer getting this issue assigned to them, had I not requested assignment yesterday and YOU would have been assigned to the issue.

@Mahekhan If we allow this, then anyone will finish a PR and say we have already made the PR just assign it to me now. This is the exact opposite of how we are supposed to hande an issue.
Rules are rules, and technically your first contribution is issue #60 , PR #73

Can you not imagine how discouraging it is when you are very new to open source contribution, you learn a new skill (flutter in this case) to solve issues for your favourite organization, you put in time and effort to solve an issue, you are excited about making a successful PR, and then you suddenly get unassigned!

To be honest, it just feels like you are buttering up people to side you.

@techno-disaster
You are the maintainer here, you could have been kinder to me and not unassigned and let me work on this issue!
I am so new to this, I am as good as a first timer!

Like i said earlier, sorry if i was harsh but what if a legit first timer wants to contribute? and sees all first timer issues are claimed by the so called "new to flutter" people who have already contributed?
PR #73 does has 152 addtions 102 deletions, so you won't be "so new" to this

[ghost]

To be honest, it just feels like you are buttering up people to side you.

I don't know which people you are talking about. I am speaking only with you.

@Mahekhan If we allow this, then anyone will finish a PR and say we have already made the PR just assign it to me now.
No. I was first 'assigned' then I made the PR.

Like i said earlier, sorry if i was harsh but what if a legit first timer wants to contribute? and sees all first timer issues are claimed by the so called "new to flutter" people who have already contributed?
PR #73 does has 152 addtions 102 deletions, so you won't be "so new" to this

But, according to what batrek promised you would have been assigned this issue had I not requested an assignment yesterday. You wouldn't have mind that, I'm sure. And you wouldn't have acted 'the savior of the first-timers' then.

• sighs *
  You are only being defensive. And more defensive. I don't even want to continue this conversation with you anymore.
  Bye, @techno-disaster !
  Have fun stealing other people's chances. FY.

[mayburgos]

@Mahekhan Hello!

This particular issue has been raised to the @anitab-org/admins attention. We really appreciate that you took the time to solve one of our issues. I'm really sorry to hear about you feeling disappointed about our processes.

As a reminder, we follow a Code of Conduct. Our expected behavior lists:

• Exercise consideration and respect in your speech and actions.
• Attempt collaboration before conflict.
• Refrain from demeaning, discriminatory, or harassing behavior and speech.

If you do not plan to follow our Code of Conduct, then we will not accept your contributions. If you continue to break our Code of Conduct, we will have to ban you from our organization. If you have any issues about our processes and the Code of Conduct we follow, please email them directly to opensource@anitab.org.

[HaripriyaB]

@anitab-org/admins since these first-timers issues are stale for long time and we have most of the issues for first-timers only due to which other contributors are not able to claim issues. So can we(non-first-timers) take up these issues for now so that we can clear up the pending issues sooner to welcome new issues and PRs??

[isabelcosta]

@HaripriyaB I would say give it a try to some :)

[techno-disaster]

Moved to #97