Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

Don't track generated files #63

Closed
bartekpacia opened this issue May 12, 2020 · 7 comments
Closed

Don't track generated files #63

bartekpacia opened this issue May 12, 2020 · 7 comments
Labels
First Timers Only Good for newcomers. Help Wanted Extra attention is needed. Status: Available Issue was approved and available to claim or abandoned for over 3 days. Type: Maintenance Repository maintenance.

Comments

@bartekpacia
Copy link
Contributor

bartekpacia commented May 12, 2020

Describe the problem
Some of the code in this project(boilerplate to communicate with the API) is generated using chopper package. This isn't a good practice, because generated code shouldn't be included under VCS like Git (for those who have experience with JS, it's like including node_modules).

Photo example:
Screenshot 2020-05-12 at 11 53 23 PM

Expected behavior
Generated files, i.e those with chopper in their names, should be excluded (= added to the .gitignore) and removed from Git.

@bartekpacia bartekpacia added Status: Available Issue was approved and available to claim or abandoned for over 3 days. Type: Maintenance Repository maintenance. labels May 12, 2020
@techno-disaster
Copy link
Contributor

looks like a good first timer task :)

@techno-disaster techno-disaster added the First Timers Only Good for newcomers. label May 12, 2020
@bartekpacia
Copy link
Contributor Author

You're right @techno-disaster, I didn't think about this.

@mayburgos mayburgos added the Help Wanted Extra attention is needed. label May 21, 2020
@techno-disaster techno-disaster mentioned this issue Jun 11, 2020
4 tasks
@techno-disaster
Copy link
Contributor

Moved to #97

@HaripriyaB
Copy link
Contributor

Closed via #103

@techno-disaster
Copy link
Contributor

Umm #103 doesn't fix this?

@HaripriyaB
Copy link
Contributor

Umm #103 doesn't fix this?

#103 Description says it fixes Don't track generated files issue..... doesn't it??

@techno-disaster
Copy link
Contributor

techno-disaster commented Jul 9, 2020

Yes, i just saw it but i did not add it. Checking the edit history looks like @isabelcosta added it by mistake. Also #63 is not mentioned in the Fixes section. But I think we can close this as we had a small discussion at at the end of #103 to go ahead with this or not. Can you confirm @isabelcosta @bartekpacia

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
First Timers Only Good for newcomers. Help Wanted Extra attention is needed. Status: Available Issue was approved and available to claim or abandoned for over 3 days. Type: Maintenance Repository maintenance.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants