This repository has been archived by the owner on Jan 26, 2021. It is now read-only.
Update gh action #126
Merged
Update gh action #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 3, 2020 16:23
This ci does whatever the previous ci (cleaner code tho) did but it additionally uploads the apk for each PR to github artifacts which can be donwloaded by the qa team to make their testing easier. So basically the tester from qa team will not have to use an android emulator or install flutter to test PRs on this repo anymore. Just download the artifact from below each PR :)
Won't skip warnings hence removed for now
techno-disaster
added
Category: Quality Assurance
techno-disaster
requested review from
bartekpacia and
isabelcosta
as code owners
HaripriyaB
previously approved these changes
Aug 4, 2020
|
@techno-disaster can you solve the merge conflict and then I can approve and merge this? |
|
@anitab-org/mentorship-flutter-maintainers done :) |
isabelcosta
approved these changes
Aug 5, 2020
There was a problem hiding this comment.
Thank you @techno-disaster this is amazing! I can't wait to see this in the works
robotjellyzone
approved these changes
Aug 9, 2020
isabelcosta
added
Status: Ready to Merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This ci does whatever the previous ci (cleaner code tho) did but it additionally uploads the apk for each PR to github artifacts which can be donwloaded by the qa team to make their testing easier. So basically the tester from qa team will not have to use an android emulator or install flutter to test PRs on this repo anymore. Just download the artifact from below each PR :)
Fixes #127
Flutter Channel:
Type of Change:
Delete irrelevant options.
Code/Quality Assurance Only
How Has This Been Tested?
Code/Quality Assurance Only