-
Notifications
You must be signed in to change notification settings - Fork 59
Conversation
Update[1]
Update [02]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@anitab-org/qa-team can someone test this? |
@bharat-1809 can you please fix the merge conflict here so we can review this again and merge once approved? |
@isabelcosta Sure! |
@isabelcosta I have resolved the conflicts! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
@techno-disaster can you test this and show the proof here please :) If you feel this is working as expected then feel free to merge |
Ok, Ill test this. i guess i need to update docs on the artifacts thingy asap. https://github.com/anitab-org/mentorship-flutter/pull/130/checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested this pr and its working in the way it should 👍 .
The changes made in this PR were tested locally. Following are the results:
-
Code Review: Done
-
All possible responses were tested as below:
Screenshot/gif:
Expected Result: adding sections in the task tab
Actual Result: Same as above
- Additional testcases covered: n/a
- Device : PIXEL XL API 27
@robotjellyzone thank you so much for your help testing this PR 🙌 |
Description
This PR adds sections in the task tab of the relations page. To-do and achieved tasks are separated using an expandable panel.
Fixes #95
Flutter Channel:
Type of Change:
Code/Quality Assurance Only
How Has This Been Tested?
This is tested on a physical device.
Steps:
Here is a working demo of the same
Checklist:
Code/Quality Assurance Only