Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

feat: add sections in task tab #130

Merged
merged 8 commits into from
Sep 21, 2020
Merged

Conversation

bharat-1809
Copy link
Contributor

Description

This PR adds sections in the task tab of the relations page. To-do and achieved tasks are separated using an expandable panel.

Fixes #95

Flutter Channel:

  • I have used the Flutter Beta channel on my local machine

Type of Change:

  • Code

Code/Quality Assurance Only

  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

This is tested on a physical device.

Steps:

  • Goto Relations Page
  • Click on the Tasks Tab

Here is a working demo of the same

20200811_125924

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

Code/Quality Assurance Only

  • My changes generate no new warnings

@isabelcosta isabelcosta added the Status: Needs Review PR needs an additional review or a maintainer's review. label Aug 11, 2020
Copy link
Contributor

@techno-disaster techno-disaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@techno-disaster
Copy link
Contributor

@anitab-org/qa-team can someone test this?

@isabelcosta
Copy link
Member

@bharat-1809 can you please fix the merge conflict here so we can review this again and merge once approved?

@bharat-1809
Copy link
Contributor Author

@isabelcosta Sure!

@bharat-1809
Copy link
Contributor Author

@isabelcosta I have resolved the conflicts!

Copy link
Member

@isabelcosta isabelcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@isabelcosta isabelcosta added Status: Needs Testing Work has been reviewed and needs the code tested by the quality assurance team. and removed Status: Needs Review PR needs an additional review or a maintainer's review. labels Sep 4, 2020
@isabelcosta
Copy link
Member

@techno-disaster can you test this and show the proof here please :) If you feel this is working as expected then feel free to merge

@techno-disaster
Copy link
Contributor

Ok, Ill test this. i guess i need to update docs on the artifacts thingy asap. https://github.com/anitab-org/mentorship-flutter/pull/130/checks

@Akanksha1212 Akanksha1212 added the Category: Coding Changes to code base or refactored code that doesn't fix a bug. label Sep 13, 2020
Copy link

@robotjellyzone robotjellyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this pr and its working in the way it should 👍 .
The changes made in this PR were tested locally. Following are the results:

  1. Code Review: Done

  2. All possible responses were tested as below:
    Screenshot/gif:

sectionsTaskTested

Expected Result: adding sections in the task tab
Actual Result: Same as above

  1. Additional testcases covered: n/a
  2. Device : PIXEL XL API 27

@robotjellyzone robotjellyzone added Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer. and removed Status: Needs Testing Work has been reviewed and needs the code tested by the quality assurance team. labels Sep 17, 2020
@isabelcosta isabelcosta merged commit 53521aa into anitab-org:develop Sep 21, 2020
@isabelcosta
Copy link
Member

@robotjellyzone thank you so much for your help testing this PR 🙌

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make separate sections for tasks to do and tasks completed
5 participants