Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

docs: Add Travis Build Badge #52

Merged
merged 1 commit into from
May 8, 2020
Merged

docs: Add Travis Build Badge #52

merged 1 commit into from
May 8, 2020

Conversation

gaurivn
Copy link
Member

@gaurivn gaurivn commented May 8, 2020

Description

Added Travis Build Badge.

Fixes #47

Flutter Channel:

  • I have used the Flutter Beta channel on my local machine

Type of Change:

Delete irrelevant options.

  • Documentation

How Has This Been Tested?

Describe the tests you ran to verify your changes. Provide instructions or GIFs so we can reproduce. List any relevant details for your test.

Checklist:

Delete irrelevant options.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have made corresponding changes to the documentation

Copy link
Member

@isabelcosta isabelcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @gaurivn 🎉
Thank you so much for your contribution :)

@gaurivn
Copy link
Member Author

gaurivn commented May 8, 2020

Thank you @isabelcosta

Copy link
Contributor

@techno-disaster techno-disaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@techno-disaster techno-disaster merged commit 0140fd9 into anitab-org:develop May 8, 2020
@techno-disaster
Copy link
Contributor

oh wait i did not see the master branch sorry. We won't be using it. Should i revert this merge @isabelcosta ?

@isabelcosta
Copy link
Member

No problem I did not notice either. You can just create an issue and fix that, it does not seem like a dangerous change :) @techno-disaster do you agree with this solution?

@techno-disaster
Copy link
Contributor

No problem I did not notice either. You can just create an issue and fix that, it does not seem like a dangerous change :) @techno-disaster do you agree with this solution?

sure. reverting can mess up git according to my experience. Should i make a issue or can i just send a PR? seems like a really small change :)

@isabelcosta
Copy link
Member

Can you create an issue plzzzz, and your issues are quite short, so I see no problem in creating an issue, and claim it there, then submitting a PR, to keep track of the why, you are fixing something that came from this PR. I promise to be quick to review 🙃 @techno-disaster

@techno-disaster
Copy link
Contributor

Can you create an issue plzzzz, and your issues are quite short, so I see no problem in creating an issue, and claim it there, then submitting a PR, to keep track of the why, you are fixing something that came from this PR. I promise to be quick to review upside_down_face @techno-disaster

ah yes sure, I shoudn't be lazy + i will try to be more descriptive in my PRs @isabelcosta. will do it asap

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Travis Build Badge
3 participants