-
Notifications
You must be signed in to change notification settings - Fork 59
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @gaurivn 🎉
Thank you so much for your contribution :)
Thank you @isabelcosta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
oh wait i did not see the master branch sorry. We won't be using it. Should i revert this merge @isabelcosta ? |
No problem I did not notice either. You can just create an issue and fix that, it does not seem like a dangerous change :) @techno-disaster do you agree with this solution? |
sure. reverting can mess up git according to my experience. Should i make a issue or can i just send a PR? seems like a really small change :) |
Can you create an issue plzzzz, and your issues are quite short, so I see no problem in creating an issue, and claim it there, then submitting a PR, to keep track of the why, you are fixing something that came from this PR. I promise to be quick to review 🙃 @techno-disaster |
ah yes sure, I shoudn't be lazy + i will try to be more descriptive in my PRs @isabelcosta. will do it asap |
Description
Added Travis Build Badge.
Fixes #47
Flutter Channel:
Type of Change:
Delete irrelevant options.
How Has This Been Tested?
Describe the tests you ran to verify your changes. Provide instructions or GIFs so we can reproduce. List any relevant details for your test.
Checklist:
Delete irrelevant options.