feat: add confirm password field and show passwords feature to change password popUp

[bharat-1809]

Description

Add confirm password field with validation and toggle password visibility button on the change password popUp

Fixes #76

Flutter Channel:

• I have used the Flutter Beta channel on my local machine

Type of Change:

• Code

Code/Quality Assurance Only

• New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Physical Device
Steps:

• Go to the Settings page by clicking on the icon at the top right corner of the homepage.
• Click on the Change Password button to see whether the feature works properly or not
  

Checklist:

Delete irrelevant options.

• My PR follows the style guidelines of this project
• I have performed a self-review of my own code or materials
• I have commented on my code or provided relevant documentation, particularly in hard-to-understand areas

Code/Quality Assurance Only

• My changes generate no new warnings
• My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
• Any dependent changes have been published in downstream modules

[techno-disaster]

@bharat-1809 can you attach a video showing how the new change password dialog works now?

[bharat-1809]

@bharat-1809 can you attach a video showing how the new change password dialog works now?

Sure

[bharat-1809]

Link to the video

[techno-disaster]

Link to the video

Please try to attach a gif next time onwards :)

[bharat-1809]

Link to the video

Please try to attach a gif next time onwards :)

Sure😅

[bartekpacia]

looks good, thank you🎉

[techno-disaster]

The confirm password and show password features work as expected, but due to a prior bad merge, the change password dialog box dosen't respond correctly and the snackbar isn't showed. (BuildContext error). #83 fixes this. So lets merge this PR after that to confirm if the whole change password function works. Thanks for your work @bharat-1809

[bharat-1809]

Okay cool, thanks😃

[bartekpacia]

Nice!

[techno-disaster]

@bharat-1809 we follow a theme in our app, where if you click to show one of the show passsword eye icons all the fields show the password, can you do the same in the change password dialog window fields? Thank you

[bharat-1809]

Yeah sure, I'll definitely do it. I have a little doubt, whether the eye icon will be displayed on all the fields or only one on the topmost field?
Thanks :)

[techno-disaster]

Yeah sure, I'll definitely do it. I have a little doubt, whether the eye icon will be displayed on all the fields or only one on the topmost field?
Thanks :)

on all fields :)

[bharat-1809]

@techno-disaster I have made the required changes please have a look.
Thanks

Here's a gif of the same:

[bharat-1809]

@bartekpacia Is that review dismissal automatic? because I didn't do it. 😅

[robotjellyzone]

I have already tested this PR here --> #92 (review)

so, LGTM 🎉 thanks for your contribution @bharat-1809 👍

ALSO, please check/mark that "I have used the Flutter Beta channel on my local machine" section in the description of this PR .

[techno-disaster]

Fix merge conflict

[bharat-1809]

Fix merge conflict

Its done. @techno-disaster please have a look :)
Thanks

[techno-disaster]

Can someone from @anitab-org/qa-team give this a test? it was tested before but to confirm nothing broke after the merging the conflict can someone give this another check? Thank You

[robotjellyzone]

The changes made in this PR were tested locally. Following are the results:

Code review - Done By @techno-disaster

All possible responses (positive and negative tests) were tested as below:

Tested confirm password field , its validation with show passwords feature to change password popUp:

Screenshot/gif:

1. Allow updating the password even when new password is not matching with confirm password :

2. Not Showing missing confirm password field message even if its empty :

Expected Result :

• When we write a password in confirm password field then it should match with the new password field.
• if left empty, it should reflect it as a missing field and should not allow to update the password until it gets all the field values in the required form.

Actual Result :

• It is not correctly validating as it still allows the change in password even when both new & confirm password fields are not matching.
• Also, not showing any missing field error/popup even when confirm password field is empty

Additional testcases covered: N/A

Additional Comments: @bharat-1809 You need to make changes in your code and see , where the validation condition is breaking as both of the failed tests were only due to breaking validation case.

Status of PR : Changes Requested
Android Version: 10.0, Device: Android Emulator Pixel 3 XL API 29

[bharat-1809]

@anitab-org/maintainers Please have a look. The validation errors have been fixed

[robotjellyzone]

Now its working as --->

1. Showing missing password field -->

2. Also, shows appropriate validation message when passwords don't match -->

Great job 👍 @bharat-1809

[isabelcosta]

@techno-disaster @bartekpacia as code owners can you review this please?

[techno-disaster]

LGTM

[isabelcosta]

Thank you for your contribution @bharat-1809 👏 🎉