Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

feat: make disabled text fields appear grey on profile page #99

Merged
merged 4 commits into from
Jun 24, 2020

Conversation

bharat-1809
Copy link
Contributor

Description

Added an opacity widget that sets the opacity of the page to 50% when editing is disabled and changes to 100% when editing is enabled.

Fixes #84

Flutter Channel:

  • I have used the Flutter Beta channel on my local machine

Type of Change:

Delete irrelevant options.

  • Code

Code/Quality Assurance Only

  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Physical device.
Steps:

  • Go to the profile page by selecting it from bottom bar
  • Click on the Floating Action Button to start editing and see the changes

sample

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented on my code or provided relevant documentation, particularly in hard-to-understand areas

Code/Quality Assurance Only

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • Any dependent changes have been published in downstream modules

@bartekpacia
Copy link
Contributor

Looks cool! It'd be even nicer if you added some simple animation to it, what do you think @bharat-1809?

@techno-disaster
Copy link
Contributor

Looks cool! It'd be even nicer if you added some simple animation to it, what do you think @bharat-1809?

@bartekpacia what kind of animation are we talking about? because we already have #83 which adds loading indicators.

@bartekpacia
Copy link
Contributor

bartekpacia commented Jun 12, 2020

Sorry for not specifying; I mean fading the opacity.

@bharat-1809
Copy link
Contributor Author

@bartekpacia sure, I'll start working on it :)

@bartekpacia
Copy link
Contributor

Thank you, it'll look and feel better this way:)

PS If you don't feel like doing it, just write, I'll accept this because it's already great work.

@bharat-1809
Copy link
Contributor Author

@bartekpacia Thanks ☺, I have no problem in doing it and would love to contribute :))
Thanks again.

@techno-disaster
Copy link
Contributor

Hey, @bharat-1809 any updates?

@rpattath rpattath added the Status: Changes Requested Changes are required to be done by the PR author. label Jun 16, 2020
@bharat-1809
Copy link
Contributor Author

@techno-disaster Sorry for the delay, I will make the changes surely by tonight.

@bharat-1809
Copy link
Contributor Author

I have added the fading animation. Please have a look and suggest any changes if required.
Thanks :)

20200616_164928

@bartekpacia
Copy link
Contributor

This looks great, thank you!:D

Copy link

@robotjellyzone robotjellyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviwed & tested this PR , and its working fine as it should 👍 .

tested_pr

@robotjellyzone robotjellyzone added Category: Coding Changes to code base or refactored code that doesn't fix a bug. Category: User Interface Improvements or additions to design. and removed Status: Changes Requested Changes are required to be done by the PR author. labels Jun 20, 2020
@rpattath rpattath added the Status: Needs Testing Work has been reviewed and needs the code tested by the quality assurance team. label Jun 23, 2020
@isabelcosta
Copy link
Member

@techno-disaster can you please review and approve if you feel it should be.

Copy link
Contributor

@techno-disaster techno-disaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, goof work :)

@techno-disaster techno-disaster merged commit 48318c4 into anitab-org:develop Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Category: User Interface Improvements or additions to design. Status: Needs Testing Work has been reviewed and needs the code tested by the quality assurance team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make disabled textfields grey on profile page
6 participants