Skip to content
This repository has been archived by the owner on May 5, 2020. It is now read-only.

About View Update #401

Merged
merged 2 commits into from Apr 23, 2020
Merged

About View Update #401

merged 2 commits into from Apr 23, 2020

Conversation

anubhavpulkit
Copy link
Contributor

Description

I think About view is more beautiful and impactful if it looks normal without any complexity, So I send this PR to present the same.

Fixes #243

Type of Change:

Delete irrelevant options.

  • Code
  • Quality Assurance
  • User Interface

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

about view.mov.zip

Checklist:

Delete irrelevant options.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • Any dependent changes have been merged

Code/Quality Assurance Only

  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules

@anubhavpulkit
Copy link
Contributor Author

@sunjunkie I think is the final one, and you like😀.

@anubhavpulkit
Copy link
Contributor Author

@sunjunkie please have a look new commit 7b98af2

@sunjunkie
Copy link
Contributor

Looks great.

@sunjunkie sunjunkie closed this Apr 22, 2020
@anubhavpulkit
Copy link
Contributor Author

anubhavpulkit commented Apr 23, 2020

Then why you close this PR without merge? If is look great Im working on this issue from so many day @sunjunkie ☹️

@sunjunkie sunjunkie reopened this Apr 23, 2020
@sunjunkie sunjunkie self-requested a review April 23, 2020 05:59
@sunjunkie
Copy link
Contributor

Did not mean to close this without merging!

@sunjunkie sunjunkie merged commit 0d2ca2e into anitab-org:develop Apr 23, 2020
@anubhavpulkit
Copy link
Contributor Author

Thank You @sunjunkie 😁

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modifying AboutView Controller
2 participants