Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

Add missing unit tests #29

Closed
5 tasks done
vubo opened this issue Jun 4, 2015 · 12 comments
Closed
5 tasks done

Add missing unit tests #29

vubo opened this issue Jun 4, 2015 · 12 comments

Comments

@vubo
Copy link
Contributor

vubo commented Jun 4, 2015

  • Add missing unit tests in organization/tests.py
  • Add missing unit tests in event/tests.py
  • Add missing unit tests in job/tests.py
  • Add missing unit tests in shift/tests.py
  • Add missing unit tests in volunteer/tests.py
@vubo
Copy link
Contributor Author

vubo commented Jun 4, 2015

Add missing unit tests in organization/tests.py #28

@willingc
Copy link
Contributor

willingc commented Jun 4, 2015

I like this!

GitHub tip: You can make checkboxes using GitHub markdown. Check out https://guides.github.com/features/mastering-markdown/ in the Task Lists section.

@vubo
Copy link
Contributor Author

vubo commented Jun 4, 2015

@willingc It looks very cool, thank you!
tasks

@willingc
Copy link
Contributor

willingc commented Jun 4, 2015

Nice. It is pretty cool :)

@jayesh92
Copy link
Contributor

jayesh92 commented Jun 5, 2015

@willingc @vubo Would It be a good idea to include the functional tests in this repo or should I include it in AUT repo. Benefit in first case is that I can integrate it with CI so all new code pushed passes throught these tests also.
I'm currently doing this on my local instance. For this we'll need to change the directory structure a bit. Instead of tests.py each app will contain a tests folder and an __init__.py . All tests need to be put up in this folder namely, unit-tests and functional tests.
Your views ? The respective commit for this can be seen in my fork jayesh92/vms@d7b5d93 and directory structure at https://github.com/jayesh92/vms/tree/master/vms/home
Above tests are included during CI. Corresponding travis build at https://travis-ci.org/jayesh92/vms

willingc added a commit that referenced this issue Jun 5, 2015
Add unit test for delete_organization and if statement
Addresses one task in issue #29
@willingc
Copy link
Contributor

willingc commented Jun 5, 2015

Hmm...good questions. Nice job asking for thoughts and feedback.
I'm not yet sure what would be best. I would like to clarify with the other team members what their vision is longer term related to:

  • Python version support 2.7.10 or 3.4+
  • Django version support - recommend 1.8LTS

Would you both raise these questions on your weekly reports for discussion? It looks like Systers/portal is already using Python 3.4 and Django 1.7.7. I would recommend that VMS match their Django infrastructure, but this really is a discussion for a larger audience :)

Please feel free to continue discussing thoughts or ideas here too.

@vubo
Copy link
Contributor Author

vubo commented Jun 7, 2015

Add missing unit tests in event/tests.py: #36

@vubo
Copy link
Contributor Author

vubo commented Jun 9, 2015

Add missing unit tests in job/tests.py: #38

@willingc
Copy link
Contributor

@vubo You are making good progress on this issue. Let's try to get the remaining two done this week. I'll do a detailed review this weekend.

You may wish to do a quick skim of coverage.py docs, tox, and some of Harry Percival's Test Driven Development book (http://obeythetestinggoat.com). We'll likely use all of these when adding new features.

@vubo
Copy link
Contributor Author

vubo commented Jun 11, 2015

@willingc yes, I will finish the tests before Sunday then.

@vubo
Copy link
Contributor Author

vubo commented Jun 13, 2015

Add missing unit tests in shift/tests.py: #43

@vubo vubo mentioned this issue Jun 13, 2015
4 tasks
@vubo
Copy link
Contributor Author

vubo commented Jun 13, 2015

Add missing unit tests in volunteer/tests.py: #47

@vubo vubo closed this as completed Jun 28, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants