Update deprecated api #411

rareboe · 2019-07-03T05:55:25Z

remove IInAppBillingService.aidl file and added Google Play Billing Library.
update deprecated API

- remove Warning:Configuration 'compile' replaced with 'implementation' - update targetSdkVersion 26 (Google Play requires that apps target API level 26 or higher) - remove IInAppBillingService.aidl file and Use the Google Play Billing Library - update deprecated API

serggl · 2019-07-04T13:51:04Z

library/src/main/java/com/anjlab/android/iab/v3/BillingProcessor.java

@@ -782,11 +782,11 @@ public boolean consumePurchase(String productId)
 		try
 		{
 			TransactionDetails transaction = getPurchaseTransactionDetails(productId, cachedProducts);
-			if (transaction != null && !TextUtils.isEmpty(transaction.purchaseToken))
+			if (transaction != null && !TextUtils.isEmpty(transaction.purchaseInfo.purchaseData.purchaseToken))


what is the purpose of this change? can you elaborate

The TransactionDetails.purchaseToken field has been deprecated. so used purchaseInfo.purchaseData.purchaseToken field.

I bet behaviour will depend on the google play services version installed on a device.
I would do this in a non-breaking manner, checking for both old and new values

this function use TransactionDetails instance.
TransactionDetails class constructor.
public TransactionDetails(PurchaseInfo info)
{
purchaseInfo = info;
productId = purchaseInfo.purchaseData.productId;
orderId = purchaseInfo.purchaseData.orderId;
purchaseToken = purchaseInfo.purchaseData.purchaseToken;
purchaseTime = purchaseInfo.purchaseData.purchaseTime;
}

so used purchaseInfo.purchaseData.purchaseToken field.

@serggl Can we Merge ?

mustii82 · 2019-07-16T00:43:44Z

What about a new Release?

serggl · 2019-07-16T08:51:36Z

done ✅

DennyWeinberg · 2019-07-16T18:32:58Z

Thanks! Anything to pay attention to? Just update to 45? I read something about "Acknowledge purchases" that needs to be done in v3?
@mustii82

rareboe · 2019-07-18T01:25:35Z

@DennyWeinberg This issue solves the problem in the screenshot.

#406 This issue maybe not application issue. Because this library is using version 3 or higher.
Declaration : Constants.GOOGLE_API_VERSION
Use code : BillingProcessor

I manage a lot of projects, and those warnings were mostly APIs that the server calls.
Check version 'googleapis.com/androidpublisher/{version}/applications' from caller.

DennyWeinberg · 2019-07-18T15:16:15Z

@jin-conbus, thanks! So I think we all are not talking about the same topic, after checking #406 and #160. I'm not sure if you could leave a comment in the open issues to clarify and to make understand everybody whats going on...?
If I understand right, this library already uses v3, so we are fine for end of 2019 and we don't need to worry. The merged pull request was about another topic.

Thanks again!

stereomatch · 2019-07-18T20:54:34Z

@DennyWeinberg @jin-conbus @mustii82

DennyWeinberg is referring to this issue discussed on r/androiddev in his comment above:

Thanks! Anything to pay attention to? Just update to 45? I read something about "Acknowledge purchases" that needs to be done in v3?

The question is, if anjlab is now using Google Play Billing Library version 2.0 (in x.45 ?), then will we need to change our code to acknowledge purchases explicitly.

Or is anjlab doing that somewhere already - if not, the usage guidelines should be updated, so a user can change their code that uses anjlab accordingly.

References:

https://www.reddit.com/r/androiddev/comments/bmvvey/in_app_billing_aidl_deprecated/
In App Billing AIDL deprecated
Tolriq

https://www.reddit.com/r/androiddev/comments/bsgfx6/play_store_automatic_refunds_after_72_hours/
Posted byu/Andriensis
Play Store automatic refunds after 72 hours?

https://developer.android.com/google/play/billing/billing_library_releases_notes

Google Play Billing Library 2.0 Release (2019-05-07)
Version 2.0 of the Google Play Billing library is now available. This version contains the following changes.
Purchases must be acknowledged within three days

Pending transactions
With version 2.0 of the Google Play Billing library, you must support purchases where additional action is required before granting entitlement.

stereomatch · 2019-07-18T21:23:49Z

@DennyWeinberg @jin-conbus @mustii82

Also just to be clear about versions, and under what conditions the AIDL error was appearing for some developers:

Google Play Billing library is version 2.0.x (latest)
anjlab v3 1.0.45 now uses Google Play Billing library version 2.0.x, and does not use the AIDL way of doing things (this therefore avoids the error message some were getting about the use of AIDL)

I was not getting any error about use of AIDL when using:
anjlab-iabv3-1.0.44.jar

but the app was targeting API 27 - perhaps the AIDL error starts appearing when you target API 28 ?

Or it appears if some developers were using some specific API call in anjlab ?

rareboe · 2019-07-19T05:36:20Z

@stereomatch
What you're talking about is likely to be talking about using 'BillingClient'.
However, we are currently using IInAppBillingService.
We can use it as it is.

use 'com.android.billingclient:billing:2.0.1' only bottom reason
AIDL is now deprecated and will be removed in a future release.

But we can still use the old method.
Because include 'IInAppBillingService' and can use interface.

stereomatch · 2019-07-19T08:56:23Z

@jin-conbus

So if I understand it correctly, we have 3 different versions that maybe relevant to anjlab ?

anjlab 1.0.44 and 1.0.45 (recently updated)
Google Play Billing library 1.2.2 and 2.0 - are both anjlab 1.0.44 and 1.0.45 using 1.2.2 (using AIDL method, and not switched to 2.0 yet ?)
Google Play Developer API v2 and v3 - I don't know why this is relevant to anjlab, but maybe anjlab uses some APIs from this library

The Google Play Developer API v2/v3 issue seems to be related to these threads:

#402
Changes to the Google Play Developer API #402

https://github.com/idehub/react-native-billing/issues/160
Update to Google Play Developer API v3 (v2 end of life Dec 2019) #160

The Google Play Billing library 1.2.2 is being used by both anjlab 1.0.44 and 1.0.45 ? That is, both use the AIDL method ?

https://developer.android.com/google/play/billing/billing_library_releases_notes
Google Play Billing Library

Google Play Billing Library 2.0 Release (2019-05-07)

Google Play Billing Library 1.2.2 Release (2019-03-07)

I ask because your first comment above seems to suggest otherwise:

remove IInAppBillingService.aidl file and Use the Google Play Billing Library
update deprecated API

You also said:

What you're talking about is likely to be talking about using 'BillingClient'.
However, we are currently using IInAppBillingService.
We can use it as it is.

use 'com.android.billingclient:billing:2.0.1' only bottom reason
AIDL is now deprecated and will be removed in a future release.

But we can still use the old method.
Because include 'IInAppBillingService' and can use interface.

So "IInAppBillingService" is only used when you are using the AIDL method (and Google Play Billing library 1.2.2) - correct ?

Will anjlab be updated to stop using the AIDL method (and "IInAppBillingService"), and switch to Google Play Billing library 2.0 (which doesn't use AIDL) ?

rareboe · 2019-07-19T10:21:42Z

@stereomatch

So if I understand it correctly, we have 3 different versions that maybe relevant to anjlab ? :

Before anjlab 1.0.45, And anjlab 1.0.45 also uses AIDL interface.

The Google Play Developer API v2/v3 issue seems to be related to these threads :

As I mentioned above, those warnings were mostly APIs that the server calls.
Check version 'googleapis.com/androidpublisher/{version}/applications' from caller.

The Google Play Billing library 1.2.2 is being used by both anjlab 1.0.44 and 1.0.45 ? That is, both use the AIDL method ? :

anjlab library use AIDL method.

I ask because your first comment above seems to suggest otherwise :

I understood why you asked.(Corrected this comment.) IinappBillingService.aidl is removed to use the latest AIDL method and the AIDL method provided by the Google Play Billing Library is used. (The update deprecated API refers to the portion deprecated in anjlab as mentioned above.)

So "IInAppBillingService" is only used when you are using the AIDL method (and Google Play Billing library 1.2.2) - correct ? :

Yes

Will anjlab be updated to stop using the AIDL method (and "IInAppBillingService"), and switch to Google Play Billing library 2.0 (which doesn't use AIDL) ? :

Perhaps it will.

stereomatch · 2019-07-23T14:32:34Z

Thanks.

So clarifying further:

anjlab 1.0.44, and even 1.0.45 (which fixes the error with "IinappBillingService"), STILL uses the AIDL method, but a newer variant of it, which avoids the "IinappBillingService" error.
anjlab 1.0.44, and even 1.0.45 stil uses Google Play Billing library 1.2.x (and not 2.0 yet)
a future version of anjlab may start to support Google Play Billing library 2.0 - at which point anjlab will stop using the AIDL method
the "Google Play Developer API v2/v3 issue" is a separate issue, unrelated to the eventual transition to Google Play Billing library 1.2.x (AIDL) to 2.0

xDragonZ · 2019-08-16T11:03:07Z

So this PR is still using aidl and purchase no need to be acknowledged yet?

stereomatch · 2019-08-17T17:07:25Z

So this PR is still using aidl and purchase no need to be acknowledged yet?

@xDragonZ that is my impression.

* - update gradle version 3.1.0 - remove Warning:Configuration 'compile' replaced with 'implementation' - update targetSdkVersion 26 (Google Play requires that apps target API level 26 or higher) - remove IInAppBillingService.aidl file and Use the Google Play Billing Library - update deprecated API * sample project use annotations version 26.0.1 * revert compileSdkVersion and buildToolsVersion * revert gradle version

anjlab#413

rareboe added 4 commits July 3, 2019 11:44

sample project use annotations version 26.0.1

24db0db

revert compileSdkVersion and buildToolsVersion

3fb1886

revert gradle version

4045368

mustii82 mentioned this pull request Jul 4, 2019

[supply] Update to Google Play Developer API v3 (v2 end of life Dec 2019) #406

Closed

serggl reviewed Jul 4, 2019

View reviewed changes

serggl merged commit 450b46d into anjlab:master Jul 15, 2019

serggl added a commit that referenced this pull request Jul 16, 2019

bump build version to 45 to accomodate #315,#376,#411,#413

5bf9620

beshoo mentioned this pull request Sep 11, 2019

What about (acknowledges) is it supported? #425

Open

arneee mentioned this pull request Feb 8, 2020

[CRITICAL][BUG] Refunded in app product marked as bought #435

Open

virusman mentioned this pull request May 10, 2020

Migration to Google Play billing #441

Closed

showdpro pushed a commit to showdpro/android-inapp-billing-v3 that referenced this pull request Jul 13, 2021

bump build version to 45 to accomodate anjlab#315,anjlab#376,anjlab#411,

8d89370

anjlab#413

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update deprecated api #411

Update deprecated api #411

rareboe commented Jul 3, 2019 •

edited

Loading

serggl Jul 4, 2019

rareboe Jul 5, 2019

serggl Jul 5, 2019

rareboe Jul 5, 2019

mustii82 Jul 12, 2019

mustii82 commented Jul 16, 2019

serggl commented Jul 16, 2019

DennyWeinberg commented Jul 16, 2019 •

edited

Loading

rareboe commented Jul 18, 2019

DennyWeinberg commented Jul 18, 2019

stereomatch commented Jul 18, 2019 •

edited

Loading

stereomatch commented Jul 18, 2019

rareboe commented Jul 19, 2019

stereomatch commented Jul 19, 2019 •

edited

Loading

rareboe commented Jul 19, 2019 •

edited

Loading

stereomatch commented Jul 23, 2019

xDragonZ commented Aug 16, 2019

stereomatch commented Aug 17, 2019

Update deprecated api #411

Update deprecated api #411

Conversation

rareboe commented Jul 3, 2019 • edited Loading

serggl Jul 4, 2019

Choose a reason for hiding this comment

rareboe Jul 5, 2019

Choose a reason for hiding this comment

serggl Jul 5, 2019

Choose a reason for hiding this comment

rareboe Jul 5, 2019

Choose a reason for hiding this comment

mustii82 Jul 12, 2019

Choose a reason for hiding this comment

mustii82 commented Jul 16, 2019

serggl commented Jul 16, 2019

DennyWeinberg commented Jul 16, 2019 • edited Loading

rareboe commented Jul 18, 2019

DennyWeinberg commented Jul 18, 2019

stereomatch commented Jul 18, 2019 • edited Loading

stereomatch commented Jul 18, 2019

rareboe commented Jul 19, 2019

stereomatch commented Jul 19, 2019 • edited Loading

rareboe commented Jul 19, 2019 • edited Loading

stereomatch commented Jul 23, 2019

xDragonZ commented Aug 16, 2019

stereomatch commented Aug 17, 2019

rareboe commented Jul 3, 2019 •

edited

Loading

DennyWeinberg commented Jul 16, 2019 •

edited

Loading

stereomatch commented Jul 18, 2019 •

edited

Loading

stereomatch commented Jul 19, 2019 •

edited

Loading

rareboe commented Jul 19, 2019 •

edited

Loading