Added match phrase option #412
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request @pluton-house. Can you add tests with the expected behavior? |
|
OK, tests added, I welcome feedback on my code :-) |
|
👍 |
|
Was this added in another PR? Why does it still open? |
|
When will this be merged? Have been waiting for this feature for quite some time! |
|
Would love to see this merged. Thanks! |
|
Sorry for being slow on feedback @pluton-house. I worried the approach for testing introduces unneeded complexity. I think it's better to be more explicit with the expected results (have the actual product names in the assertion). Also, take advantage of Minitest's |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides the option to request the query to apply to a phrase. For example, to offer different matching options such as 'all words', 'any words' or 'exact phrase', this mod provides the last option.