Add support for conversions boost term #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @sarchak, thanks for the PR, including tests 💯 Can we call it |
|
@ankane by default |
|
Let's go with |
Change conversions_boost_term to conversions_term
sarchak
force-pushed
the
sarchak/conversion_boost_term
branch
from
d57cabe
to
8887942
Compare
|
Done! |
|
Looks great, thanks! 👍 |
sarchak
added a commit
to instacart/searchkick
that referenced
this pull request
Jun 15, 2017
Change conversions_boost_term to conversions_term
mikelkew
added a commit
to mikelkew/searchkick
that referenced
this pull request
Jul 18, 2017
* commit '9c957ffd9a6bc5c356ead1ea445cac2e9b6d4369': (25 commits) Prefer default_fields if specified [skip ci] Use Elasticsearch 5.5 as default for tests [skip ci] Upgraded ES6 test version [skip ci] Clarify error message [skip ci] Ensure _all isn't indexed in ES 6 [skip ci] Added _all and default_fields options Version bump to 2.3.1 Updated changelog [skip ci] Don't call minimum twice, and handle no record case better Switch to find_in_batches and find the first PK to see if's a Numeric Clarify filterable and add test Updated filterable docs [skip ci] Correctly pass the id of the batch Remove un-necessary search information from the Sku model Reindex non-numerical PK's in batches Add failing test for non-integer primary key models Updated readme for conversions_term [skip ci] Add support for conversions boost term (ankane#933) Fixed page_view_entries for Kaminari - fixes ankane#934 Added test for no fields [skip ci] ...
mikelkew
added a commit
to mikelkew/searchkick
that referenced
this pull request
Jul 18, 2017
* master: (26 commits) Prefer default_fields if specified [skip ci] Use Elasticsearch 5.5 as default for tests [skip ci] Upgraded ES6 test version [skip ci] Clarify error message [skip ci] Ensure _all isn't indexed in ES 6 [skip ci] Added _all and default_fields options Version bump to 2.3.1 Updated changelog [skip ci] Don't call minimum twice, and handle no record case better Switch to find_in_batches and find the first PK to see if's a Numeric Clarify filterable and add test Updated filterable docs [skip ci] Correctly pass the id of the batch Remove un-necessary search information from the Sku model Reindex non-numerical PK's in batches Add failing test for non-integer primary key models Updated readme for conversions_term [skip ci] Add support for conversions boost term (ankane#933) Fixed page_view_entries for Kaminari - fixes ankane#934 Added test for no fields [skip ci] ...
mikelkew
added a commit
to mikelkew/searchkick
that referenced
this pull request
Jul 18, 2017
* master: (26 commits) Prefer default_fields if specified [skip ci] Use Elasticsearch 5.5 as default for tests [skip ci] Upgraded ES6 test version [skip ci] Clarify error message [skip ci] Ensure _all isn't indexed in ES 6 [skip ci] Added _all and default_fields options Version bump to 2.3.1 Updated changelog [skip ci] Don't call minimum twice, and handle no record case better Switch to find_in_batches and find the first PK to see if's a Numeric Clarify filterable and add test Updated filterable docs [skip ci] Correctly pass the id of the batch Remove un-necessary search information from the Sku model Reindex non-numerical PK's in batches Add failing test for non-integer primary key models Updated readme for conversions_term [skip ci] Add support for conversions boost term (ankane#933) Fixed page_view_entries for Kaminari - fixes ankane#934 Added test for no fields [skip ci] ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Currently, when boosting on conversions we use the term for boosting. This PR will add support to have separate conversion boost term.
One way to improve search results is if we can have separate terms for matching and boosting.
Example :
We need a way to use the existing conversions for boosting (using popularity for boosting) and be more flexible with matching. In our case match would be with "banana" and conversions boosting will be with "organic banana"
cc @ankane @meetrajesh