Derive Debug and Clone for MstlParams
#7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sd2k
changed the title
Debug and Clone for Stl, Mstl, and MstlParams
|
Thanks @sd2k, think it makes sense to do for |
|
Happy to remove that if you want, I was mostly following the debuggability API guidelines. I guess it bloats the code slightly? |
|
Let's remove it. |
Similar to ankane#5.
sd2k
force-pushed
the
mstl-debug-clone
branch
from
0d2f282
to
e0a9cda
Compare
sd2k
changed the title
Debug and Clone for Stl, Mstl, and MstlParamsDebug and Clone for MstlParams
|
@ankane Done, good to go now 👍 |
|
Thanks @sd2k! Will try to get a release out in the next hour. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #5.