Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve maps of oceans #264

Closed
axelboc opened this issue Apr 10, 2020 · 4 comments · Fixed by #325
Closed

Improve maps of oceans #264

axelboc opened this issue Apr 10, 2020 · 4 comments · Fixed by #325
Labels
content Content changes, map improvements, translation fixes, etc.
Milestone

Comments

@axelboc
Copy link
Collaborator

axelboc commented Apr 10, 2020

Identified in #1 (comment)

Should ocean maps be made more consistent with locator maps? If they are fine as is, then I'll refocus this issue on the map of the Southern Ocean, which is inconsistent with the other ocean maps.

ug-map-atlantic_ocean
ug-map-southern_ocean

@axelboc axelboc added the content Content changes, map improvements, translation fixes, etc. label Apr 10, 2020
@aplaice
Copy link
Collaborator

aplaice commented Apr 10, 2020

Some options are:

  1. Leave them as they are.

  2. Add a transparent background to the ones that don't have one yet.

    • by getting them SVGised (upstream), by tracing or a similar method

    • by regenerating them as an SVG (from scratch) but with the same projection and the same boundaries as currently

    • by editing the PNGs to add transparency (this is non-trivial, or at least non-trivial if you don't have the right tools (?))

  3. Adapting the remainder to the style of the Southern Ocean one.

  4. Edit them to follow the continents' maps' style. They could look something like this:

    ug-map-atlantic_ocean

    (I followed the boundaries of the Atlantic Ocean set in our current map without thinking about whether they make much sense, for the time being.)

    • However, the Southern and Arctic Oceans might need to be treated alternatively anyway. (I'm not sure how well they'd look — I could try them, if you think it's worth it — it's not very much effort. Antarctica looks OK according to the current continent maps' style, so they might not be too badly brutalised either.)
  5. If the continent style is changed (Improve maps of continents #265), then that of the oceans could also be adjusted to match.

    • However, as I wrote there I don't see much scope for changing them — zooming in so that only the given continent/ocean is visible might look silly.

@axelboc
Copy link
Collaborator Author

axelboc commented Apr 11, 2020

I'm definitely for option 4 or 5.

I really like your version of the Atlantic Ocean map, so I'd be happy with option 4. One downside is that the Pacific Ocean would be split in two. Not a big deal, but for argument's sake, how difficult would it be to centre the Winkel III projection on another meridian?

@aplaice
Copy link
Collaborator

aplaice commented Apr 11, 2020

Not a big deal, but for argument's sake, how difficult would it be to centre the Winkel III projection on another meridian?

Relatively easy. (I had done that for some of the sea maps.)

Actually, since the continent maps are centred on 15 ° (which avoids eastern-most Russia getting split), it might be better to use that for the remaining seas. (I hadn't bothered with the sea maps, since using 0 ° made things minimally easier, at least to start off with, it didn't matter for the "main" parts of the maps and wasn't really visible in the "mini map".)

I probably won't have time to get things done today or tomorrow, though. :/

@axelboc
Copy link
Collaborator Author

axelboc commented Apr 11, 2020

Oh no rush, all of these can wait for v3.4. There's already way too much in v3.3! 😄

aplaice added a commit to aplaice/anki-ultimate-geography that referenced this issue Jun 14, 2020
aplaice added a commit to aplaice/anki-ultimate-geography that referenced this issue Jun 19, 2020
aplaice added a commit to aplaice/anki-ultimate-geography that referenced this issue Jun 19, 2020
@axelboc axelboc added this to the v4.0 milestone Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Content changes, map improvements, translation fixes, etc.
Development

Successfully merging a pull request may close this issue.

2 participants