-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloze-like Style Card Templates #118
Conversation
Getting up to date
Get Latest
As mentioned in the issue, I'm reluctant to make the change, specifically for two reasons:
That being said, I have yet to give these templates a try ... and I will, promise! 😄 Regarding the |
Totally understandable, and what I expected. Since I feel strongly that this is an improvement for these flashcards, I thought I would put in the effort of making the change itself. It still must be discussed further and tested, that is expected. But making the pull request makes it easier to discuss the exact changes proposed, and allows people to try it out too. Whatever is eventually decided, s'no big deal 👍 Also, if it helps, I overwrote my own cards with different versions of this layout several times, and I lost no progress. |
I've had a play with your cloze-style templates @ohare93. Here my thoughts so far:
I've tried to make a version of the templates where the "Country" type is not explicitly shown, and where the country always appears at the top, even on the flag and map templates. Here are the zips, let me know what you think: |
Very indepth look, thank you! Thanks for the deck share, it was useful to take a look. I'm glad you can see the benefits, and I generally agree with everything you said. Your concerns are valid, and I passed my mind too. Now, specifics: Country Top/Bottom: As you said, having Country be on bottom can be confusing at times, but it was in an attempt to mitagate the immediate concern you raised: that info below the screen would be missed. Though with correct application of the Styling: Originally I added the colours to attempt to distinguish Country and Capital, then when even that didn't work I changed it to this Cloze-style. I suppose I just left the colours as I'd gotten used to it. I admit looking at your cards I was initially turned off by how grey and dull they looked, but it quickly lost it's impact and I'm sure I'd get used to it in no time. Also sure, one "?" looks fine. Regardless it is incredibly minor, not the hill I wish to die on! 😅 "Country" for Water/Continents/Islands: I had the same general idea, of using javascript to search the tags for "UG:Oceans+Seas" and replacing the "Country" title with "Ocean/Sea". Which is easy enough to do. But just not showing "Country" at all very much saves us the trouble 💯 👍 I am entirely onboard with that. Consistency is very important, and while I believe implementing these Cloze-type cards will inherently bring some benefits (more consistency being one of them!) I do agree that your proposed changes to my suggestion are more in line with the deck and bring further consistency. I have no proposed changes to your cards as they stand 🥇 What next then? 😉 |
I have finally found the time to get the Github project setup for this wonderful project, and finalize my Cloze-like style templates for all card types. I have made all card types have the same Cloze-like style, to maintain a consistent look. I also removed some useless parts of the styling, trying to consolidate it a bit.
Here's a preview of each card type:
Also in the process I upgraded to the Extended deck type (though I'll be going through those cards slowly). One thing I do not understand (so I may have done it wrong) is why there is a different Card Type for "Country - Capital EXT"? As all cards are now cloze-like, in this build, this one seems useless, but I have left it in for now.
I hope this is enough to satisfy Issue #90. Thanks again for the great deck! Happy to contribute in the future.