Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos found by @ukanuk's script #351

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Conversation

aplaice
Copy link
Collaborator

@aplaice aplaice commented Jul 4, 2020

https://github.com/ukanuk/scratchpad-public-viewing/blob/master/ug_to_wp/data_wikipedia_20200425.csv

  • (ES) Rumanía is a correct spelling, but not the main one.
  • (DE) Nursultan is a correct spelling, but not the main one.
  • (ES) Did not fix: technically, the Spanish article for Astana/Nur-Sultan still has Astaná as the article name, and just says "oficialmente Nursultán". I expect this to change eventually and don't want learners to have the name yanked back-and-forth...
  • (DE) Sri Jayawardenepura Kotte is spelt "Sri Jayewardenepura Kotte" in German. (!?)
  • (DE) Aschgabat is the correct German spelling, but Aşgabat is the version used as the article title on German Wikipedia.
  • (EN) Brasília is the spelling used for the article title (not Brasilia).
  • (DE) German Wikipedia has a full stop for the abbreviation in "St. Lucia".

I have completely ignored discrepancies between src/data.csv and Norwegian Wikipedia (as listed in the generated CSV), since I assumed that the discrepancies were due to the main Norwegian source not being Wikipedia).

In the long run, the script will hopefully be polished, allowing greater (or even full) automation, but in the mean-time, and in case it doesn't happen, I didn't want the fixes @ukanuk had found to get lost.

I didn't re-run the script to avoid hammering Wikipedia's servers needlessly.

(See also #293.)

@axelboc axelboc added the content Content changes, map improvements, translation fixes, etc. label Jul 13, 2020
@axelboc axelboc added this to the v4.1 milestone Jul 13, 2020
@axelboc axelboc merged commit c9fb8c4 into anki-geo:master Jul 13, 2020
@aplaice aplaice deleted the script_typos branch January 2, 2021 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Content changes, map improvements, translation fixes, etc.
Development

Successfully merging this pull request may close these issues.

None yet

2 participants