Add zoomboxes for disambiguation #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Love your work!! 😍 If I really had to nitpick, perhaps the zoom boxes of Macau, Hong Kong, Comoros, and Mayotte are a tiny bit too zoomed in... but it's really insignificant, so feel free to upload as is. |
|
The zoomed-in maps that I'm relying on for these four zoom boxes don't have much more context, so it'd be relatively hard to zoom out. Hence, if it's not that much of an issue, I'll leave them as they are! |
|
Fair enough, sounds good 👍 |
axelboc
added
the
content
aplaice
force-pushed
the
disambiguate_hong_kong_et_al
branch
from
cb2ce46
to
8f8d3d6
Compare
aplaice
changed the title
Disambiguate Hong Kong and Macau, Guernsey and Jersey, Mayotte and Comoros. Fix anki-geo#314, anki-geo#344.
aplaice
force-pushed
the
disambiguate_hong_kong_et_al
branch
from
8f8d3d6
to
fa8196e
Compare
|
Woops, sorry, forgot to merge this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disambiguate Hong Kong and Macau, Guernsey and Jersey, Mayotte and
Comoros.
Fix #314, fix #344.
Maps before and after
Hong Kong
Macau
Guernsey
Jersey
Mayotte
Comoros
As usual, if the maps are OK, I'll upstream to Wikimedia and update
sources.csv.(Note that for Guernsey, in the zoombox I selected all the islands making up the Bailiwick of Guernsey, not just the island (or the jurisdiction) of Guernsey. (See also #241, which in-itself is no longer relevant due to the removal of the flags of small dependent territories, but which dealt with virtually the same issue.) I think that the issue is now more clear-cut since it's the Bailiwick which is a
Crown Dependency, as stated in theCountry info, not the Juridiction which is a sub-unit of the Bailiwick.)