Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Dutch translation #378

Merged
merged 18 commits into from
Jan 20, 2021
Merged

Added Dutch translation #378

merged 18 commits into from
Jan 20, 2021

Conversation

WouterVdS
Copy link
Contributor

@WouterVdS WouterVdS commented Jan 20, 2021 •
edited

#313 Dutch Translation

@WouterVdS WouterVdS mentioned this pull request Jan 20, 2021
Closed
ohare93
ohare93 reviewed Jan 20, 2021
View reviewed changes
Copy link
Member

@ohare93 ohare93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one small catch. I will do a test run of it too 👍

recipes/legacy_csv_to_split_csvs.yaml Outdated Show resolved Hide resolved
@ohare93
Copy link
Member

ohare93 commented Jan 20, 2021

Test run successful 🎉 The Dutch deck looks great! 😁 (from a cursory glance!)

@WouterVdS
Copy link
Contributor Author

Fixed the missing 'nl'. And thanks!

axelboc
axelboc approved these changes Jan 20, 2021
View reviewed changes
Copy link
Collaborator

@axelboc axelboc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @WouterVdS (also for documenting the Russian translation in the README)!! ❤️

src/data/country_info.csv Outdated Show resolved Hide resolved
aplaice
aplaice approved these changes Jan 20, 2021
View reviewed changes
src/headers/desc.html Outdated Show resolved Hide resolved
src/data/capital_info.csv Outdated Show resolved Hide resolved
@aplaice
Copy link
Collaborator

aplaice commented Jan 20, 2021

Extreme-pedantry and an error-caused-by-me aside, this looks amazing! Thanks so much!

@WouterVdS
Copy link
Contributor Author

Extreme-pedantry and an error-caused-by-me aside, this looks amazing! Thanks so much!

Happy to contribute! Wrote a small python script to open a Google search for the list of English countries, one every eight seconds. This way I could follow along in the .csv while Google showed me the country info in my own language!

@aplaice
Copy link
Collaborator

aplaice commented Jan 20, 2021

Happy to contribute! Wrote a small python script to open a Google search for the list of English countries, one every eight seconds. This way I could follow along in the .csv while Google showed me the country info in my own language!

That's pretty clever!

@aplaice aplaice merged commit f978c18 into anki-geo:master Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohare93 ohare93 ohare93 left review comments

@axelboc axelboc axelboc approved these changes

@aplaice aplaice aplaice approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@WouterVdS @ohare93 @aplaice @axelboc