Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define and document sources and inclusion rules for oceans, seas, straits, channels and passages #379

Merged
merged 1 commit into from
Jan 31, 2021

Conversation

axelboc
Copy link
Collaborator

@axelboc axelboc commented Jan 24, 2021

Fix #346.

Like for political entities, I've added a spreadsheet to list the water bodies and test/document the inclusion criteria. It contains three groups for now: seas, straits and channels/passages (seemed to make sense to group the last two together, as passages are closer to channels than straits in my mind). I haven't added continents and oceans to the spreadsheet since we don't need to apply any criteria to them.

Note that it might be a good idea to double check the >= 2 states columns for straits and channels/passages in case Wikidata returned any wrong or arguable results.

@axelboc
Copy link
Collaborator Author

axelboc commented Jan 24, 2021

Here are all the entities that need to be added to the deck:

Seas Straits Channels and passages
  • Andaman Sea
  • Arafura Sea
  • Baffin Bay
  • Banda Sea
  • Barents Sea
  • Beaufort Sea
  • Bering Sea
  • Bismarck Sea
  • Celebes Sea
  • Chukchi Sea
  • East China Sea
  • Great Australian Bight
  • Greenland Sea
  • Gulf of Aden
  • Gulf of Alaska
  • Gulf of Guinea
  • Gulf of Saint Lawrence
  • Ionian Sea
  • Java Sea
  • Kara Sea
  • Laccadive Sea
  • Laptev Sea
  • Molucca Sea
  • North Sea
  • Ross Sea
  • Scotia Sea
  • Sea of Okhotsk
  • Seram Sea
  • Solomon Sea
  • Sulu Sea
  • Timor Sea
  • Tyrrhenian Sea
  • Weddell Sea
  • Bab-el-Mandeb
  • Strait of Magellan
  • Strait of Gibraltar
  • Singapore Strait
  • Strait of Dover
  • Palk Strait
  • Strait of Hormuz
  • Torres Strait
  • Strait of Malacca
  • Mozambique Channel

And the ones that need to be removed:

  • White Sea
  • Denmark Strait

If the inclusion rules are confirmed, I'll create an issue to keep track of these additions/removals.

@aplaice
Copy link
Collaborator

aplaice commented Jan 24, 2021

On a cursory view (unfortunately, I currently don't have time for a thorough review, and likely won't this week), both the changes to CONTRIBUTING.md and the physical-entities.xlsx spreadsheet look great and in line with what we had discussed!

Copy link
Collaborator

@aplaice aplaice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still haven't had time to properly review (i.e. double check everything in the spreadsheet), but that's not reason to delay merging even longer!

@axelboc
Copy link
Collaborator Author

axelboc commented Jan 31, 2021

Alright, merging now then! 🚀

I'll try to do a release next week.

@axelboc axelboc merged commit 253529e into master Jan 31, 2021
@axelboc axelboc deleted the water-bodies branch January 31, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Inclusion rules for seas and related water bodies
2 participants