Define and document sources and inclusion rules for oceans, seas, straits, channels and passages #379
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #346.
Like for political entities, I've added a spreadsheet to list the water bodies and test/document the inclusion criteria. It contains three groups for now: seas, straits and channels/passages (seemed to make sense to group the last two together, as passages are closer to channels than straits in my mind). I haven't added continents and oceans to the spreadsheet since we don't need to apply any criteria to them.
Note that it might be a good idea to double check the
>= 2 states
columns for straits and channels/passages in case Wikidata returned any wrong or arguable results.