Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Swedish translation #382

Merged
merged 6 commits into from
Jan 31, 2021
Merged

Add Swedish translation #382

merged 6 commits into from
Jan 31, 2021

Conversation

emiham
Copy link
Collaborator

@emiham emiham commented Jan 30, 2021

I looked at the PR for the Czech translation, and I should have replicated the changes apart from the legacy recipes, but please take a look and check that everything looks okay.

Copy link
Member

@ohare93 ohare93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Only a couple of (very ironic) missing translations that I can see:

  • Country Info of Scandinavia
  • Capital Info of European Union

Apart from that it looks good to me 👍 (though I cannot attest for the accuracy of the translation, though it's easier to do so than the Russian one! 😆)

@emiham
Copy link
Collaborator Author

emiham commented Jan 31, 2021

They were somewhat intentional — I figured if you live in one of the Scandinavian countries you know which ones they are. That being said, on second thought I realized you don't have to live there to use the language, so they're fixed now!

@ohare93
Copy link
Member

ohare93 commented Jan 31, 2021

Great, thanks 👍 We'll merge as soon another Contributer also reviews and approves 😁

Thanks again for your work!

@aplaice
Copy link
Collaborator

aplaice commented Jan 31, 2021

This looks great! Thanks!


Extremely pedantic hat on:

In src/data/capital_info.csv, (and possibly src/data/country_info.csv), for consistency, the phrases/sentences should end in full stops.

General aside

(AFAICT, we have the convention that the capital_info and country_info fields end in full stops, while the capital_hint and flag_similarity ones don't, because the former group at least sometimes contains full sentences, while the latter are always phrases. However, most of the country infos are also simple phrases (e.g. Constituent country of X or Island of X). The only "country info" that is actually a sentence that I could find, at least in English, was for the Sea of Japan. In contrast, almost all of the capital infos are sentences (e.g. Cetinje is an honorary capital.). Hence:

a) Should we revise the (currently unofficial) convention?

b) Should we document it in CONTRIBUTING.md?

c) Are the rules (about what constitutes a complete sentence) different in different languages? (There are some languages where "to be" can be omitted and only be "implicitly" present. (Approximately, "This table." means "This is a table.").)

I'll open a separate issue about this.

In the meantime, ideally, I'd suggest having the Swedish capital_infos (at least those that are sentences) end in full stops, but in any case, it's not a major issue.)


Slightly pedantic hat on (related to #381):

I think that slightly too many alternative and old names are listed, but I don't think that (mostly) they need removing. We're already currently inconsistent here (particularly in the case of the Norwegian translation), so some more inconsistency won't hurt.

I'd mildly prefer Quelpart (for Jeju) and Kitega (for Gitega/Burundi) to be removed, though, since they seem to be colonial era names (Quelpart was used by Europeans until the Japanese occupation (i.e. until the early 20th century), while Kitega was the name given to the city by its German, colonial founders (I haven't found any mention of how long it was used...)), and make me feel like a colonialist European... (For comparison, we don't mention Ceylon as an alternative name for Sri Lanka.) However, again, it's not a blocker.

src/headers/desc.html Outdated Show resolved Hide resolved
Co-authored-by: aplaice <plaice.adam+github@gmail.com>
Copy link
Collaborator

@axelboc axelboc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!! 😍

@axelboc axelboc merged commit f619c71 into anki-geo:master Jan 31, 2021
@axelboc axelboc linked an issue Jan 31, 2021 that may be closed by this pull request
@emiham
Copy link
Collaborator Author

emiham commented Jan 31, 2021

Extremely pedantic hat on

Extremely pedantic is good!

In src/data/capital_info.csv, (and possibly src/data/country_info.csv), for consistency, the phrases/sentences should end in full stops.

I'll share my thoughts about this in the issue.

I think that slightly too many alternative and old names are listed, but I don't think that (mostly) they need removing. We're already currently inconsistent here (particularly in the case of the Norwegian translation), so some more inconsistency won't hurt.

I agree.

Wikipedia listed a lot of alternative spellings that I don't know if they are relevant, but I figured it would be easier to remove them if they're superfluous rather than going through all the pages again to add them. For what it's worth I have a list of probably a little over ten ones that I didn't add because they lacked info fields in any other language, so I did show some restraint!

I'd mildly prefer Quelpart (for Jeju) and Kitega (for Gitega/Burundi) to be removed, though, since they seem to be colonial era names (Quelpart was used by Europeans until the Japanese occupation (i.e. until the early 20th century), while Kitega was the name given to the city by its German, colonial founders (I haven't found any mention of how long it was used...)), and make me feel like a colonialist European... (For comparison, we don't mention Ceylon as an alternative name for Sri Lanka.) However, again, it's not a blocker.

This is a difficult issue, and it's hard not to be opinionated about this. My instinct was to go by the newer name if that's what the region itself prefers, as long as it's reasonably accepted by the rest of the world. It seems that Wikipedia's policy is that it has to be more established though, and as long as that's what we go by it seems we have to follow. Probably the most notable one was Eswatini, which has changed on English Wikipedia, but not on Swedish (and not for a lack of trying, there's a long discussion about it on the Talk page).

That being said I'm obviously fine with changing any of them, just let me know!

@axelboc
Copy link
Collaborator

axelboc commented Jan 31, 2021

@emiham do you think you'd have time to open an issue so that we could review all the cases you found were inconsistent and/or contentious? (or maybe just add to #381?)

@aplaice
Copy link
Collaborator

aplaice commented Jan 31, 2021

but I figured it would be easier to remove them if they're superfluous rather than going through all the pages again to add them.

Yeah, that definitely makes sense!


Also, I appreciate the thoroughness! (Looking at Talk pages etc.)

@emiham
Copy link
Collaborator Author

emiham commented Jan 31, 2021

@emiham do you think you'd have time to open an issue so that we could review all the cases you found were inconsistent and/or contentious? (or maybe just add to #381?)

I'll add to the issue a little later!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Swedish translation
4 participants