-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upstream most sea maps #445
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's now more-or-less conformant with IHO 1953. It still differs from IHO 2002 considerably, but slightly less so.
Now its limits are in line with both IHO 1953 and 2002.
It's now in line with IHO 2002. (1953 didn't have it.)
I remember previously deliberately excluding it, but I don't remember why, and since both IHO 1953 and IHO 2002 include it, I'm following them.
The license has changed from CC BY-SA 3.0 to CC BY-SA 4.0, because while uploading to Wikimedia I only realised half-way the upload process that the default license was CC BY-SA 4.0 not 3.0, and switching to 4.0 for only half the maps would have been worse than switching to 4.0 for all of them. The Tasman Sea is sort-of upstreamed, but I've realised that in this case, I had previously been accidentally doing something more correctly than now: The IHO definitions (and the shapefiles) contain "straight lines". According to IHO 1953 these are supposed to be rhumb lines (geodesics/parts of great circles). My map generation pipeline used to do sort-of the right thing (convert long line segments into approximate geodesics), under some circumstances, but fail catastrophically under others (not interpolate some long lines at all, resulting in, for instance, completely wrong Oceanic boundaries). From what I remember, the relevant `densify` options didn't help, in these cases, so I started "densifying" long lines with a custom script. This fixed the catastrophic failures, but because I was densifying incorrectly (assuming that the lines were in flat Euclidean space...), apparently also made some of the boundaries slightly worse. Visually comparing all images, the deterioration seems to only have occurred in the case of the Tasman Sea. Hence, I don't want to set the upstream of our Tasman Sea map to the new, slightly worse SVG. Instead, I'll (hopefully, at some point) fix the densification script (it shouldn't be hard, just slightly fiddly), update the version uploaded to Wikimedia and then update sources.csv.
axelboc
approved these changes
Aug 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Impressive work, well done 👏👏👏
axelboc
added
the
content
Content changes, map improvements, translation fixes, etc.
label
Aug 8, 2021
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream most sea maps
The license has changed from CC BY-SA 3.0 to CC BY-SA 4.0, because while uploading to Wikimedia I only realised half-way the upload process that the default license was CC BY-SA 4.0 not 3.0, and switching to 4.0 for only half the maps would have been worse than switching to 4.0 for all of them.
The Tasman Sea is sort-of upstreamed, but I've realised that in this case, I had previously been accidentally doing something more correctly than now:
The IHO definitions (and the shapefiles) contain "straight lines". According to IHO 1953 these are supposed to be rhumb lines (geodesics/parts of great circles).
My map generation pipeline used to do sort-of the right thing (convert long line segments into approximate geodesics), under some circumstances, but fail catastrophically under others (not interpolate some long lines at all, resulting in, for instance, completely wrong Oceanic boundaries). From what I remember, the relevant
densify
options didn't help, in these cases, so I started "densifying" long lines with a custom script. This fixed the catastrophic failures, but because I was densifying incorrectly (assuming that the lines were in flat Euclidean space...), apparently also made some of the boundaries slightly worse. Visually comparing all images, the deterioration seems to only have occurred in the case of the Tasman Sea.Hence, I don't want to set the upstream of our Tasman Sea map to the new, slightly worse SVG. Instead, I'll (hopefully, at some point) fix the densification script (it shouldn't be hard, just slightly fiddly), update the version uploaded to Wikimedia and then update sources.csv.
Adjust limits of White Sea to fit IHO 1953/2002
Include ths Strait of Tartary in the Sea of Okhotsk
I remember previously deliberately excluding it, but I don't remember why, and since both IHO 1953 and IHO 2002 include it, I'm following them.
Improve Gulf of Carpentaria map
It's now in line with IHO 2002. (1953 didn't have it.)
Improve Gulf of California map (southern limit)
Now its limits are in line with both IHO 1953 and 2002.
Improve the map of the East Siberian Sea slightly
It's now more-or-less conformant with IHO 1953. It still differs from IHO 2002 considerably, but slightly less so. (Edit: I've realised that the geodesic issue also affected the East Siberian Sea, but in this case, I think that the new map is still a mild improvement, on net.)