Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream most sea maps #445

Merged
merged 6 commits into from
Aug 8, 2021
Merged

Upstream most sea maps #445

merged 6 commits into from
Aug 8, 2021

Conversation

aplaice
Copy link
Collaborator

@aplaice aplaice commented Aug 7, 2021

Upstream most sea maps

The license has changed from CC BY-SA 3.0 to CC BY-SA 4.0, because while uploading to Wikimedia I only realised half-way the upload process that the default license was CC BY-SA 4.0 not 3.0, and switching to 4.0 for only half the maps would have been worse than switching to 4.0 for all of them.

The Tasman Sea is sort-of upstreamed, but I've realised that in this case, I had previously been accidentally doing something more correctly than now:

The IHO definitions (and the shapefiles) contain "straight lines". According to IHO 1953 these are supposed to be rhumb lines (geodesics/parts of great circles).

My map generation pipeline used to do sort-of the right thing (convert long line segments into approximate geodesics), under some circumstances, but fail catastrophically under others (not interpolate some long lines at all, resulting in, for instance, completely wrong Oceanic boundaries). From what I remember, the relevant densify options didn't help, in these cases, so I started "densifying" long lines with a custom script. This fixed the catastrophic failures, but because I was densifying incorrectly (assuming that the lines were in flat Euclidean space...), apparently also made some of the boundaries slightly worse. Visually comparing all images, the deterioration seems to only have occurred in the case of the Tasman Sea.

Hence, I don't want to set the upstream of our Tasman Sea map to the new, slightly worse SVG. Instead, I'll (hopefully, at some point) fix the densification script (it shouldn't be hard, just slightly fiddly), update the version uploaded to Wikimedia and then update sources.csv.

Adjust limits of White Sea to fit IHO 1953/2002

Include ths Strait of Tartary in the Sea of Okhotsk

I remember previously deliberately excluding it, but I don't remember why, and since both IHO 1953 and IHO 2002 include it, I'm following them.

Improve Gulf of Carpentaria map

It's now in line with IHO 2002. (1953 didn't have it.)

Improve Gulf of California map (southern limit)

Now its limits are in line with both IHO 1953 and 2002.

Improve the map of the East Siberian Sea slightly

It's now more-or-less conformant with IHO 1953. It still differs from IHO 2002 considerably, but slightly less so. (Edit: I've realised that the geodesic issue also affected the East Siberian Sea, but in this case, I think that the new map is still a mild improvement, on net.)

It's now more-or-less conformant with IHO 1953.  It still differs from
IHO 2002 considerably, but slightly less so.
Now its limits are in line with both IHO 1953 and 2002.
It's now in line with IHO 2002. (1953 didn't have it.)
I remember previously deliberately excluding it, but I don't remember
why, and since both IHO 1953 and IHO 2002 include it, I'm following
them.
The license has changed from CC BY-SA 3.0 to CC BY-SA 4.0, because
while uploading to Wikimedia I only realised half-way the upload
process that the default license was CC BY-SA 4.0 not 3.0, and
switching to 4.0 for only half the maps would have been worse than
switching to 4.0 for all of them.

The Tasman Sea is sort-of upstreamed, but I've realised that in this
case, I had previously been accidentally doing something more
correctly than now:

The IHO definitions (and the shapefiles) contain "straight lines".
According to IHO 1953 these are supposed to be rhumb
lines (geodesics/parts of great circles).

My map generation pipeline used to do sort-of the right thing (convert
long line segments into approximate geodesics), under some
circumstances, but fail catastrophically under others (not interpolate
some long lines at all, resulting in, for instance, completely wrong
Oceanic boundaries).  From what I remember, the relevant `densify`
options didn't help, in these cases, so I started "densifying" long
lines with a custom script.  This fixed the catastrophic failures, but
because I was densifying incorrectly (assuming that the lines were in
flat Euclidean space...), apparently also made some of the boundaries
slightly worse.  Visually comparing all images, the deterioration
seems to only have occurred in the case of the Tasman Sea.

Hence, I don't want to set the upstream of our Tasman Sea map to the
new, slightly worse SVG.  Instead, I'll (hopefully, at some point) fix
the densification script (it shouldn't be hard, just slightly fiddly),
update the version uploaded to Wikimedia and then update sources.csv.
Copy link
Collaborator

@axelboc axelboc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive work, well done 👏👏👏

@axelboc axelboc added the content Content changes, map improvements, translation fixes, etc. label Aug 8, 2021
@axelboc axelboc added this to the v4.2 milestone Aug 8, 2021
@aplaice aplaice merged commit 91dea33 into anki-geo:master Aug 8, 2021
@aplaice
Copy link
Collaborator Author

aplaice commented Aug 8, 2021

Thanks!

@aplaice aplaice deleted the sea_sources branch August 9, 2021 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Content changes, map improvements, translation fixes, etc.
Development

Successfully merging this pull request may close these issues.

None yet

2 participants