Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize flag of Indonesia and add viewBox to flag of Eswatini #578

Merged
merged 2 commits into from
Oct 10, 2022

Conversation

aplaice
Copy link
Collaborator

@aplaice aplaice commented Oct 10, 2022

I think that the viewBox for Indonesia is needed, while it doesn't seem to be for Eswatini (maybe because the "internal" size is the same as the "external" size?). I've added it in to Eswatini for consistency.

In other words: the image for the flag of Indonesia definitely does need fixing, while that for Eswatini probably doesn't, but the change doesn't hurt.

I think that the viewBox for Indonesia is needed, while it doesn't
seem to be for Eswatini (maybe because the "internal" size is the same
as the "external" size?).  I've added it in to Eswatini for
consistency.
Copy link
Collaborator

@axelboc axelboc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@axelboc axelboc added the content Content changes, map improvements, translation fixes, etc. label Oct 10, 2022
@axelboc axelboc added this to the v5.2 milestone Oct 10, 2022
@axelboc axelboc added chore Documentation, licenses, repository structure, dependency upgrades, etc. and removed content Content changes, map improvements, translation fixes, etc. labels Oct 10, 2022
@aplaice aplaice merged commit f2f1984 into anki-geo:master Oct 10, 2022
@aplaice aplaice deleted the old_flags_sizes branch October 10, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Documentation, licenses, repository structure, dependency upgrades, etc.
Development

Successfully merging this pull request may close these issues.

None yet

2 participants