Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flag similarities #88

Merged
merged 7 commits into from Jul 9, 2019
Merged

Add flag similarities #88

merged 7 commits into from Jul 9, 2019

Conversation

axelboc
Copy link
Collaborator

@axelboc axelboc commented Apr 23, 2019

  • Add flag similarities to Egypt, Iraq, Syria and Yemen - fixes Add more flag similarity info #50
  • Make the distinction between coats of arms and emblems in flag similarities (Wappen/Emblem in German?)

@axelboc axelboc added this to the v3.2 milestone Apr 23, 2019
@axelboc
Copy link
Collaborator Author

axelboc commented Apr 23, 2019

Hi @Erim24, would you mind double checking the translations, please? 🙏

@axelboc axelboc mentioned this pull request Apr 23, 2019
Closed
Erim24
Erim24 approved these changes Apr 27, 2019
View reviewed changes
Copy link
Collaborator

@Erim24 Erim24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some suggestions but otherwise it looks good.
Regarding the distinction of Emblem and Wappen in german: I checked the wikipedia articles and there it is used the same way (in some cases as in Egypt and El Slavador they use it as synonyms)

src/data.csv Outdated Show resolved Hide resolved
src/data.csv Outdated Show resolved Hide resolved
src/data.csv Outdated Show resolved Hide resolved
src/data.csv Outdated Show resolved Hide resolved
@axelboc axelboc merged commit c4441fe into master Jul 9, 2019
@axelboc axelboc deleted the add-flag-similarities branch July 9, 2019 18:24
@axelboc axelboc added the content Content changes, map improvements, translation fixes, etc. label Jul 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erim24 Erim24 Erim24 approved these changes

Assignees
No one assigned
Labels
content Content changes, map improvements, translation fixes, etc.
Milestone
v3.2
Development

Successfully merging this pull request may close these issues.

Add more flag similarity info
2 participants
@axelboc @Erim24