Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint-rules: Enable warnings as errors #11083

Closed
david-allison opened this issue Apr 25, 2022 · 1 comment · Fixed by #11096
Closed

lint-rules: Enable warnings as errors #11083

david-allison opened this issue Apr 25, 2022 · 1 comment · Fixed by #11096
Assignees
@mikehardy
Labels
Dev Development, testing & CI
Milestone
2.16 release

Comments

@david-allison
Copy link
Member

We didn't pick up on a70c0f6

Which is a compile error in the AnkiDroid module
@david-allison david-allison added the Dev Development, testing & CI label Apr 25, 2022
@mikehardy
Copy link
Member

I'm working on this, I've got some gradle multi-module config tricks from some other repos I can drop in quickly

@mikehardy mikehardy self-assigned this Apr 25, 2022
mikehardy added a commit to mikehardy/Anki-Android that referenced this issue Apr 25, 2022
@mikehardy
fix(build): lint-rules project should use common best build practices
099b229 
extract our best-practices build settings to project-level file, apply
to all sub-projects

Fixes ankidroid#11083
@mikehardy mikehardy mentioned this issue Apr 25, 2022
Merged
mikehardy added a commit to mikehardy/Anki-Android that referenced this issue Apr 25, 2022
@mikehardy
fix(build): lint-rules project should use common best build practices
d265340 
extract our best-practices build settings to project-level file, apply
to all sub-projects

Fixes ankidroid#11083
mikehardy added a commit to mikehardy/Anki-Android that referenced this issue Apr 26, 2022
@mikehardy
fix(build): lint-rules project should use common best build practices
dd44e73 
extract our best-practices build settings to project-level file, apply
to all sub-projects

Fixes ankidroid#11083
mikehardy added a commit that referenced this issue Apr 26, 2022
@mikehardy
fix(build): lint-rules project should use common best build practices
25473ee 
extract our best-practices build settings to project-level file, apply
to all sub-projects

Fixes #11083
@github-actions github-actions bot added this to the 2.16 release milestone Apr 26, 2022
oyeraghib pushed a commit to oyeraghib/Anki-Android that referenced this issue Apr 30, 2022
@mikehardy @oyeraghib
fix(build): lint-rules project should use common best build practices
ea3ac32 
extract our best-practices build settings to project-level file, apply
to all sub-projects

Fixes ankidroid#11083
oyeraghib pushed a commit to oyeraghib/Anki-Android that referenced this issue May 14, 2022
@mikehardy @oyeraghib
fix(build): lint-rules project should use common best build practices
628865b 
extract our best-practices build settings to project-level file, apply
to all sub-projects

Fixes ankidroid#11083
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikehardy mikehardy

Labels
Dev Development, testing & CI
Projects
None yet
Milestone
2.16 release
Development

Successfully merging a pull request may close this issue.

build(deps): fix build issues mikehardy/Anki-Android
2 participants
@mikehardy @david-allison