Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permanent notifications until a daily review is done #8128

Open
edvein-rin opened this issue Feb 26, 2021 · 10 comments
Open

Permanent notifications until a daily review is done #8128

edvein-rin opened this issue Feb 26, 2021 · 10 comments
Labels

Comments

@edvein-rin
Copy link

Is your feature request related to a problem? Please describe.
It's happens that people close their notifications by a mistake (or is it only me?). So it's easy to forget about Anki's daily review if there is no reminder left.

Describe the solution you'd like
It would be nice to have an option (a checkbox in settings) to make a reminder permanent as a notification until a daily review is done. Then it just should destroy itself. Also it will be comfortable if this notification's counter of cards to review updates with new reviews done. So it would be possible to know how many cards are left just by looking at the notification after an interruption of reviews for any reason.

Additional context
I think there is no need in an additional UI update for the notification but a dynamic cards to review counter.

@welcome
Copy link

welcome bot commented Feb 26, 2021

Hello! 👋 Thanks for logging this issue. Please remember we are all volunteers here, so some patience may be required before we can get to the issue. Also remember that the fastest way to get resolution on an issue is to propose a change directly, https://github.com/ankidroid/Anki-Android/wiki/Contributing

@danishjamal104
Copy link

Is your feature request related to a problem? Please describe.
It's happens that people close their notifications by a mistake (or is it only me?). So it's easy to forget about Anki's daily review if there is no reminder left.

Describe the solution you'd like
It would be nice to have an option (a checkbox in settings) to make a reminder permanent as a notification until a daily review is done. Then it just should destroy itself. Also it will be comfortable if this notification's counter of cards to review updates with new reviews done. So it would be possible to know how many cards are left just by looking at the notification after an interruption of reviews for any reason.

Additional context
I think there is no need in an additional UI update for the notification but a dynamic cards to review counter.

Don't you think persistence notification won't have much effect as it is not a reminder but it stays their for the whole, where as reminder are meant for creating alert, rather what we can do is increase the frequency of reminders.

@edvein-rin
Copy link
Author

I agree with you, @danishjamal104. It would be much more noticeable.
Then to summarize issues' point:

  1. Add an option to choose a frequency of reminders.
  2. New notifications from reminders should contain an updated information about a number of cards to review (probably already existing issue).

@haran2248
Copy link
Contributor

@Arthur-Milchior @david-allison-1 Can you guys tell whether this issue is relevant?If yes can I work on this?

@Arthur-Milchior
Copy link
Member

Updating/destroying the notifications are clear win, as long as it does not require to much background process.
The main risk is that notification process need database access, so it risks to slow down ankidroid while the new computation is done. Not something we can do regularly.

We usually do not like adding to much options. But "reminder" is already a page by itself and is mostly empty, so I guess it would be okay to add a "+" button to add notification at multiple hours. I guess an extra button to put the notification permanent would be okay, assuming it is even possible. I mean, we already have a window mostly empty, so adding a button here does not really make the window less easy to read

@david-allison
Copy link
Member

@haran2248 It'd be great to have someone work on this, but it'd be best to consolidate discussion on #4944. It feels that we have a lot of similar issues stemming from the need for a redesign, and keeping the discussion centralised would be useful.

@github-actions

This comment was marked as resolved.

@KonstantinDjairo
Copy link

how's the current state of this?

@david-allison
Copy link
Member

AFAIK Still an issue

@KonstantinDjairo
Copy link

AFAIK Still an issue

wish we had at least an option to pin the notification , so that it can't be "cleaned" , like a persistent notification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants