Decoupling CardViewer and card content

[Arthur-Milchior]

Currently, the AbstractFlashCardViewer is very coupled with actual card content. For example mCardContent contains the question/answer text to be displayed as html, mSoundPlayer contains all sounds which are going to be played...

This mean in particular that it is currently impossible to do any work in advance, in background, since computing the list of sound is equivalent to playing it, and there is no function to compute the html content without displaying it.

At least for the code quality, decoupling a card content from the actual activity displaying the card seems useful. Hopefully, it would also be a first step toward solving #7902

[IAmJaishree]

@Arthur-Milchior do you have any suggestions or ideas for its implementation in mind already or it's a free path to explore?
I would like to work on this issue.

[Arthur-Milchior]

If you're not already working on something else, I'll happy give you this task.

I do not have anything specific in mind.
I assume that ideally, we should have a data structure which contains all the informations needed to display card content. That is:

• the text (css + html)
• the media player with media filled, not yet playing
• if it's an answer, the number of buttons to show
• Anything else I'd have missed that is used

and the reviewer or abstract flash card viewer can take this and display it's content without needing to access database at all.

[IAmJaishree]

@Arthur-Milchior I have other issues but and I raised a PR for them, I can work on this now if you want.

[Arthur-Milchior]

Then please go for it.

[github-actions]

Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

[Arthur-Milchior]

Any news @IAmJaishree ?

[dae]

@Arthur-Milchior how do you feel about this 2+ years on? Do you feel we should still keep it open?

[BrayanDSO]

I'm currently rewriting the reviewer (#14302), which include this.