Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression test: Preferences - Full Screen Gesture setting #9281

Closed
david-allison opened this issue Jul 16, 2021 · 9 comments
Closed

Regression test: Preferences - Full Screen Gesture setting #9281

david-allison opened this issue Jul 16, 2021 · 9 comments

Comments

@david-allison
Copy link
Member

david-allison commented Jul 16, 2021

See the linked comment: a bug was introduced in a past commit, and we should ensure that we check the correct constants here via unit tests.

Originally posted by @david-allison-1 in #9278 (comment)

@aryanritesh
Copy link

Hey! I am new here and I'd like to start helping. I think I can go through this issue.

@david-allison
Copy link
Member Author

Awesome! Give me a ping if you need anything

@aryanritesh
Copy link

@david-allison-1 Okay so I just went through this , so basically all I've to do is test this on my device and upload a ss right?
Or is there anything I am missing out on?

@david-allison
Copy link
Member Author

Add a unit test, then we don't need to retest it ever again

@aryanritesh
Copy link

1631378652561
@david-allison-1
I tested this and I don't see any borders, it's working fine

@david-allison
Copy link
Member Author

The full screen setting is for the reviewer, and that page isn't full screen

@aryanritesh
Copy link

@david-allison-1 what are the parameters I'd need over here for testing?

@david-allison
Copy link
Member Author

@aryanritesh I'm not sure I understand the question, what are you trying to accomplish?

The aim of this issue is to write an automated unit test which would catch the following issue:

420fb12

@github-actions
Copy link
Contributor

Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

@github-actions github-actions bot added the Stale label Nov 10, 2021
@aryanritesh aryanritesh removed their assignment Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants